From 4ce82798aabed3f8a04bca243e3b37daef7dc53c Mon Sep 17 00:00:00 2001 From: Piyush Bafna <130243298+piyushdev04@users.noreply.github.com> Date: Sat, 17 Jan 2026 23:50:08 +0530 Subject: [PATCH 1/2] [admin] Avoid loading advanced editor for commands Modified JsonSchemaWidget media property to load advanced assets only when advanced_mode=True. CommandSchemaWidget now skips loading unnecessary JS/CSS. Verified config forms load assets, commands do not. Closes #525 --- openwisp_controller/config/widgets.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/openwisp_controller/config/widgets.py b/openwisp_controller/config/widgets.py index 302171108..ea612b228 100644 --- a/openwisp_controller/config/widgets.py +++ b/openwisp_controller/config/widgets.py @@ -20,19 +20,18 @@ class JsonSchemaWidget(AdminTextareaWidget): @property def media(self): js = [ - "config/js/lib/advanced-mode.js", - "config/js/lib/tomorrow_night_bright.js", "config/js/lib/jsonschema-ui.js", "admin/js/jquery.init.js", "config/js/widget.js", "config/js/utils.js", ] css = { - "all": [ - f"config/css/{path}" - for path in ("lib/jsonschema-ui.css", "lib/advanced-mode.css") - ] + "all": ["config/css/lib/jsonschema-ui.css"] } + if self.advanced_mode: + js.insert(0, "config/js/lib/advanced-mode.js") + js.insert(1, "config/js/lib/tomorrow_night_bright.js") + css["all"].append("config/css/lib/advanced-mode.css") return forms.Media(js=js, css=css) def render(self, name, value, attrs=None, renderer=None): From 07efb68bab46196c9d0e2065769bc1b0e755a4c6 Mon Sep 17 00:00:00 2001 From: Piyush Bafna <130243298+piyushdev04@users.noreply.github.com> Date: Sun, 18 Jan 2026 00:28:11 +0530 Subject: [PATCH 2/2] [admin] Avoid loading advanced editor for commands #525 Modified JsonSchemaWidget media property to load advanced assets only when advanced_mode=True. CommandSchemaWidget now skips loading unnecessary JS/CSS. Verified config forms load assets, commands do not. Closes #525 --- openwisp_controller/config/widgets.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/openwisp_controller/config/widgets.py b/openwisp_controller/config/widgets.py index ea612b228..93ad518e9 100644 --- a/openwisp_controller/config/widgets.py +++ b/openwisp_controller/config/widgets.py @@ -25,9 +25,7 @@ def media(self): "config/js/widget.js", "config/js/utils.js", ] - css = { - "all": ["config/css/lib/jsonschema-ui.css"] - } + css = {"all": ["config/css/lib/jsonschema-ui.css"]} if self.advanced_mode: js.insert(0, "config/js/lib/advanced-mode.js") js.insert(1, "config/js/lib/tomorrow_night_bright.js")