From 3422b6231aa3ec45caa752894318a27858275d99 Mon Sep 17 00:00:00 2001 From: Miguel Marcondes Date: Sun, 11 May 2025 13:41:02 -0300 Subject: [PATCH 1/2] node-api: add warning for NAPI_EXPERIMENTAL --- src/js_native_api.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/js_native_api.h b/src/js_native_api.h index 8ef079b5158249..704d71c4d71bc8 100644 --- a/src/js_native_api.h +++ b/src/js_native_api.h @@ -21,6 +21,12 @@ #endif #endif +#if defined(NAPI_EXPERIMENTAL) && \ + !defined(NODE_API_EXPERIMENTAL_NO_WARNING) && \ + !defined(NODE_WANT_INTERNALS) +#warning "NAPI_EXPERIMENTAL is enabled. Experimental features may be unstable." +#endif + #include "js_native_api_types.h" // If you need __declspec(dllimport), either include instead, or From 5961ebfad9e9f2676cbd319c3e305b7396ee2159 Mon Sep 17 00:00:00 2001 From: Miguel Marcondes Date: Mon, 9 Jun 2025 11:35:01 -0300 Subject: [PATCH 2/2] node-api: add platform-specific warning --- src/js_native_api.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/js_native_api.h b/src/js_native_api.h index 704d71c4d71bc8..8177ace3acbb89 100644 --- a/src/js_native_api.h +++ b/src/js_native_api.h @@ -24,7 +24,13 @@ #if defined(NAPI_EXPERIMENTAL) && \ !defined(NODE_API_EXPERIMENTAL_NO_WARNING) && \ !defined(NODE_WANT_INTERNALS) -#warning "NAPI_EXPERIMENTAL is enabled. Experimental features may be unstable." +#ifdef _MSC_VER +#pragma message("NAPI_EXPERIMENTAL is enabled. " \ + "Experimental features may be unstable.") +#else +#warning "NAPI_EXPERIMENTAL is enabled. " \ + "Experimental features may be unstable." +#endif #endif #include "js_native_api_types.h"