src: remove dead code in AddFingerprintDigest

tniessen · web-flow · commit ef30a226ce65 · 2022-03-01T16:21:18.000Z
This function is never called with md_size == 0, and it would make no sense to do so in the future either. PR-URL: #42145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
@@ -431,11 +431,8 @@ void AddFingerprintDigest(
     fingerprint[(3*i)+2] = ':';
   }
 
-  if (md_size > 0) {
-    fingerprint[(3*(md_size-1))+2] = '\0';
-  } else {
-    fingerprint[0] = '\0';
-  }
+  DCHECK_GT(md_size, 0);
+  fingerprint[(3 * (md_size - 1)) + 2] = '\0';
 }
 
 template <const char* (*nid2string)(int nid)>

Original file line number	Diff line number	Diff line change
`@@ -431,11 +431,8 @@ void AddFingerprintDigest(`
`431`	`431`	`fingerprint[(3*i)+2] = ':';`
`432`	`432`	`}`
`433`	`433`
`434`		`- if (md_size > 0) {`
`435`		`- fingerprint[(3*(md_size-1))+2] = '\0';`
`436`		`- } else {`
`437`		`- fingerprint[0] = '\0';`
`438`		`- }`
	`434`	`+ DCHECK_GT(md_size, 0);`
	`435`	`+ fingerprint[(3 * (md_size - 1)) + 2] = '\0';`
`439`	`436`	`}`
`440`	`437`
`441`	`438`	`template <const char* (*nid2string)(int nid)>`