diff --git a/src/Analysis/Ast/Impl/Modules/PythonModule.cs b/src/Analysis/Ast/Impl/Modules/PythonModule.cs index a54b48e2e..67742d2bc 100644 --- a/src/Analysis/Ast/Impl/Modules/PythonModule.cs +++ b/src/Analysis/Ast/Impl/Modules/PythonModule.cs @@ -369,7 +369,7 @@ private void Parse(CancellationToken cancellationToken) { // Do not report issues with libraries or stubs if (sink != null) { - _diagnosticsService?.Replace(Uri, _parseErrors.Concat(Analysis.Diagnostics)); + _diagnosticsService?.Replace(Uri, _parseErrors); } ContentState = State.Parsed; diff --git a/src/Analysis/Ast/Impl/Modules/Resolution/MainModuleResolution.cs b/src/Analysis/Ast/Impl/Modules/Resolution/MainModuleResolution.cs index 914817b3a..3078a5da6 100644 --- a/src/Analysis/Ast/Impl/Modules/Resolution/MainModuleResolution.cs +++ b/src/Analysis/Ast/Impl/Modules/Resolution/MainModuleResolution.cs @@ -27,8 +27,8 @@ using Microsoft.Python.Analysis.Documents; using Microsoft.Python.Analysis.Types; using Microsoft.Python.Core; -using Microsoft.Python.Core.IO; using Microsoft.Python.Core.Diagnostics; +using Microsoft.Python.Core.IO; namespace Microsoft.Python.Analysis.Modules.Resolution { internal sealed class MainModuleResolution : ModuleResolutionBase, IModuleManagement { @@ -211,8 +211,5 @@ private bool TryCreateModuleStub(string name, string modulePath, out IPythonModu module = !string.IsNullOrEmpty(stubPath) ? new StubPythonModule(name, stubPath, false, _services) : null; return module != null; } - - protected override void ReportModuleNotFound(string name) - => _log?.Log(TraceEventType.Information, $"Import not found: {name}"); } } diff --git a/src/Analysis/Ast/Impl/Modules/Resolution/ModuleResolutionBase.cs b/src/Analysis/Ast/Impl/Modules/Resolution/ModuleResolutionBase.cs index c2ccc8df4..95eb766fb 100644 --- a/src/Analysis/Ast/Impl/Modules/Resolution/ModuleResolutionBase.cs +++ b/src/Analysis/Ast/Impl/Modules/Resolution/ModuleResolutionBase.cs @@ -159,7 +159,5 @@ public IPythonModule GetOrCreate(string name, ModuleResolutionBase mrb) { } } } - - protected abstract void ReportModuleNotFound(string name); } -} \ No newline at end of file +} diff --git a/src/Analysis/Ast/Impl/Modules/Resolution/TypeshedResolution.cs b/src/Analysis/Ast/Impl/Modules/Resolution/TypeshedResolution.cs index 316f58340..46342fa42 100644 --- a/src/Analysis/Ast/Impl/Modules/Resolution/TypeshedResolution.cs +++ b/src/Analysis/Ast/Impl/Modules/Resolution/TypeshedResolution.cs @@ -138,8 +138,5 @@ private bool IsPackage(string directory) => ModulePath.PythonVersionRequiresInitPyFiles(Configuration.Version) ? !string.IsNullOrEmpty(ModulePath.GetPackageInitPy(directory)) : _fs.DirectoryExists(directory); - - protected override void ReportModuleNotFound(string name) - => _log?.Log(TraceEventType.Verbose, $"Typeshed stub not found for '{name}'"); } }