Skip to content

Removed old log_diagnostic_error calls from configurator #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydvoss merged 2 commits into from
Feb 10, 2023
Merged

Removed old log_diagnostic_error calls from configurator #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d12ed18
Removed old log_diagnostic_error calls from configurator
jeremydvoss Feb 8, 2023
fb4cdb6
Made configurator error messages more descriptive
jeremydvoss Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
([#241](https://github.com/microsoft/ApplicationInsights-Python/pull/241))
- Defaulting logging env var for auto-instrumentation. Added logging samples.
([#240](https://github.com/microsoft/ApplicationInsights-Python/pull/240))
- Removed old log_diagnostic_error calls from configurator
([#242](https://github.com/microsoft/ApplicationInsights-Python/pull/242))

## [1.0.0b8](https://github.com/microsoft/ApplicationInsights-Python/releases/tag/v1.0.0b8) - 2022-09-26

Expand Down
13 changes: 9 additions & 4 deletions azure-monitor-opentelemetry-distro/azure/monitor/opentelemetry/distro/configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,28 @@
# --------------------------------------------------------------------------


import logging

from azure.monitor.opentelemetry.distro._diagnostics._diagnostic_logging import (
AzureDiagnosticLogging,
)
from opentelemetry.sdk._configuration import _OTelSDKConfigurator

_logger = logging.getLogger(__name__)


class AzureMonitorConfigurator(_OTelSDKConfigurator):
def _configure(self, **kwargs):
try:
AzureDiagnosticLogging.enable(_logger)
super()._configure(**kwargs)
except ValueError as e:
AzureDiagnosticLogging.log_diagnostic_error(
f"The components failed to initialize due to a ValueError: {e}"
_logger.error(
f"Azure Monitor Configurator failed during configuration due to a ValueError: {e}"
)
raise e
except Exception as e:
AzureDiagnosticLogging.log_diagnostic_error(
f"The components failed to initialize: {e}"
_logger.error(
f"Azure Monitor Configurator failed during configuration: {e}"
)
raise e