Player commands overloading bugs

[KirillBorunov]

I created a two variants of same command:
A) /admin skin [targetPlayerId] [skinId]
B) /admin skin [skinId]

All parameters are int.

When the server loads in the console log I see both variants are loaded:

[SampSharp:DEBUG] Registering command /admin skin [skinId]
[SampSharp:DEBUG] Registering command /admin skin [targetPlayerId] [skinId]

In game if I write /admin skin the server prints Usage: /admin skin [skinId]
If I write /admin skin 33 it prints Usage: /admin skin [targetPlayer] [skinId]
If I write /admin skin 1 33 then it works OK with the "A" variant.
It is impossible to use the "B" variant.

The commands are declared as suggested here: https://sampsharp.net/player-commands#grouping-commands
I'm not using permissions nor overriding the default commands behavior.
I tried to swap the order of the command declaration, it swapped the order of the command in the server load log, but it was not changed the behavior.

[KirillBorunov]

The problem seems to be in each of the ICommandParameterType.Parse(...) implementations.
For example this one:

SampSharp/src/SampSharp.GameMode/SAMP/Commands/ParameterTypes/IntegerType.cs

Lines 42 to 58 in d294bc0

	var text = commandText.TrimStart();
	output = null;
	if (string.IsNullOrEmpty(text))
	return false;
	var word = text.Split(' ').First();
	// Regular base 10 numbers (eg. 14143)
	if (word.All(Base10Characters.Contains) && int.TryParse(word, out var number))
	{
	commandText = commandText.Substring(word.Length).TrimStart(' ');
	output = number;
	return true;
	}

The commandText initially may contain a space at start (more on this later).
In the line 42 is doing a trim and the space is removed, so the text variable contains the same as commandText minus the initial space.
In the line 55 is doing the substring on commandText, but assuming the trim. So the resulting command text has the las symbol from the first argument, and the next run will use the remaining symbol as a second argument...

Now, the first space may or may not be present, that depends on from where the call is arriving.
The difference is inside the DefaultCommand implementation. It has a method "CanInvoke" and "Invoke".
The first one is sending the arguments without a trim, but the second is doing a trim.
That explains why the bug with the arguments is not affecting the command execution, but only the command candidate finding.

SampSharp/src/SampSharp.GameMode/SAMP/Commands/DefaultCommand.cs

Line 297 in d294bc0

commandText = commandText.Substring(name.Length);

SampSharp/src/SampSharp.GameMode/SAMP/Commands/DefaultCommand.cs

Line 330 in d294bc0

commandText = commandText.Substring(name.Value.Length).Trim();

Changing all the ICommandParameterType implementations to do a trim on the commandText instead of a new variable will fix the issue.
But also can be fixed by adding a trim to the CanInvoke mentioned line.