Skip to content

Commit 285662e

Browse files
timopollmeiergreenbonebot
authored andcommitted
Fix: Remove unused variables for add_element returns
Some unused local variables holding the return values from add_element calls are removed.
1 parent 87090ca commit 285662e

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

gvm/protocols/gmpv208/entities/filter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def create_filter(
131131
)
132132

133133
cmd = XmlCommand("create_filter")
134-
_xmlname = cmd.add_element("name", name)
134+
cmd.add_element("name", name)
135135

136136
if comment:
137137
cmd.add_element("comment", comment)

gvm/protocols/gmpv208/entities/tickets.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def clone_ticket(self, ticket_id: str) -> Any:
6666

6767
cmd = XmlCommand("create_ticket")
6868

69-
_copy = cmd.add_element("copy", ticket_id)
69+
cmd.add_element("copy", ticket_id)
7070

7171
return self._send_xml_command(cmd)
7272

@@ -114,7 +114,7 @@ def create_ticket(
114114
_user = _assigned.add_element("user")
115115
_user.set_attribute("id", assigned_to_user_id)
116116

117-
_note = cmd.add_element("open_note", note)
117+
cmd.add_element("open_note", note)
118118

119119
if comment:
120120
cmd.add_element("comment", comment)

gvm/protocols/ospv1.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def create_vt_selection_element(_xmlvtselection, vt_selection):
6363
_xmlvt.add_element("vt_value", value, attrs={"id": key})
6464
elif vt_id == "vt_groups" and isinstance(vt_values, list):
6565
for group in vt_values:
66-
_xmlvt = _xmlvtselection.add_element(
66+
_xmlvtselection.add_element(
6767
"vt_group", attrs={"filter": group}
6868
)
6969
else:
@@ -252,9 +252,8 @@ def start_scan(
252252
_xmltarget.add_element("hosts", hosts)
253253
_xmltarget.add_element("ports", ports)
254254
if credentials:
255-
_xmlcredentials = _xmltarget.add_element("credentials")
256255
_xmlcredentials = create_credentials_element(
257-
_xmlcredentials, credentials
256+
_xmltarget.add_element("credentials"), credentials
258257
)
259258
# Check target as attribute for legacy mode compatibility. Deprecated.
260259
elif target:
@@ -267,9 +266,8 @@ def start_scan(
267266
)
268267

269268
if vt_selection:
270-
_xmlvtselection = cmd.add_element("vt_selection")
271269
_xmlvtselection = create_vt_selection_element(
272-
_xmlvtselection, vt_selection
270+
cmd.add_element("vt_selection"), vt_selection
273271
)
274272

275273
return self._send_xml_command(cmd)

0 commit comments

Comments
 (0)