Define endpoint path constants in this repo instead of reusing go-github-mock

- Add endpoint pattern constants to helper_test.go
- Update code_scanning_test.go to use new constants
- Update git_test.go to use new constants
- Removes dependency on go-github-mock endpoint patterns
- Prepares for eventual removal of go-github-mock dependency

Co-authored-by: JoannaaKL <[email protected]>

Author: Copilot

pkg/github/code_scanning_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/github/github-mcp-server/pkg/translations"
 	"github.com/google/go-github/v79/github"
 	"github.com/google/jsonschema-go/jsonschema"
-	"github.com/migueleliasweb/go-github-mock/src/mock"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -51,7 +50,7 @@ func Test_GetCodeScanningAlert(t *testing.T) {
 		{
 			name: "successful alert fetch",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber.Method + " " + mock.GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber.Pattern: mockResponse(t, http.StatusOK, mockAlert),
+				GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber: mockResponse(t, http.StatusOK, mockAlert),
 			}),
 			requestArgs: map[string]interface{}{
 				"owner":       "owner",
@@ -64,7 +63,7 @@ func Test_GetCodeScanningAlert(t *testing.T) {
 		{
 			name: "alert fetch fails",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber.Method + " " + mock.GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber.Pattern: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+				GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					w.WriteHeader(http.StatusNotFound)
 					_, _ = w.Write([]byte(`{"message": "Not Found"}`))
 				}),
@@ -166,7 +165,7 @@ func Test_ListCodeScanningAlerts(t *testing.T) {
 		{
 			name: "successful alerts listing",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposCodeScanningAlertsByOwnerByRepo.Method + " " + mock.GetReposCodeScanningAlertsByOwnerByRepo.Pattern: expectQueryParams(t, map[string]string{
+				GetReposCodeScanningAlertsByOwnerByRepo: expectQueryParams(t, map[string]string{
 					"ref":       "main",
 					"state":     "open",
 					"severity":  "high",
@@ -189,7 +188,7 @@ func Test_ListCodeScanningAlerts(t *testing.T) {
 		{
 			name: "alerts listing fails",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposCodeScanningAlertsByOwnerByRepo.Method + " " + mock.GetReposCodeScanningAlertsByOwnerByRepo.Pattern: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+				GetReposCodeScanningAlertsByOwnerByRepo: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					w.WriteHeader(http.StatusUnauthorized)
 					_, _ = w.Write([]byte(`{"message": "Unauthorized access"}`))
 				}),

pkg/github/git_test.go

@@ -11,7 +11,6 @@ import (
 	"github.com/github/github-mcp-server/pkg/translations"
 	"github.com/google/go-github/v79/github"
 	"github.com/google/jsonschema-go/jsonschema"
-	"github.com/migueleliasweb/go-github-mock/src/mock"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -72,8 +71,8 @@ func Test_GetRepositoryTree(t *testing.T) {
 		{
 			name: "successfully get repository tree",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposByOwnerByRepo.Method + " " + mock.GetReposByOwnerByRepo.Pattern:                                   mockResponse(t, http.StatusOK, mockRepo),
-				mock.GetReposGitTreesByOwnerByRepoByTreeSha.Method + " " + mock.GetReposGitTreesByOwnerByRepoByTreeSha.Pattern: mockResponse(t, http.StatusOK, mockTree),
+				GetReposByOwnerByRepo:               mockResponse(t, http.StatusOK, mockRepo),
+				GetReposGitTreesByOwnerByRepoByTree: mockResponse(t, http.StatusOK, mockTree),
 			}),
 			requestArgs: map[string]interface{}{
 				"owner": "owner",
@@ -83,8 +82,8 @@ func Test_GetRepositoryTree(t *testing.T) {
 		{
 			name: "successfully get repository tree with path filter",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposByOwnerByRepo.Method + " " + mock.GetReposByOwnerByRepo.Pattern:                                   mockResponse(t, http.StatusOK, mockRepo),
-				mock.GetReposGitTreesByOwnerByRepoByTreeSha.Method + " " + mock.GetReposGitTreesByOwnerByRepoByTreeSha.Pattern: mockResponse(t, http.StatusOK, mockTree),
+				GetReposByOwnerByRepo:               mockResponse(t, http.StatusOK, mockRepo),
+				GetReposGitTreesByOwnerByRepoByTree: mockResponse(t, http.StatusOK, mockTree),
 			}),
 			requestArgs: map[string]interface{}{
 				"owner":       "owner",
@@ -95,7 +94,7 @@ func Test_GetRepositoryTree(t *testing.T) {
 		{
 			name: "repository not found",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposByOwnerByRepo.Method + " " + mock.GetReposByOwnerByRepo.Pattern: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+				GetReposByOwnerByRepo: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					w.WriteHeader(http.StatusNotFound)
 					_, _ = w.Write([]byte(`{"message": "Not Found"}`))
 				}),
@@ -110,8 +109,8 @@ func Test_GetRepositoryTree(t *testing.T) {
 		{
 			name: "tree not found",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				mock.GetReposByOwnerByRepo.Method + " " + mock.GetReposByOwnerByRepo.Pattern: mockResponse(t, http.StatusOK, mockRepo),
-				mock.GetReposGitTreesByOwnerByRepoByTreeSha.Method + " " + mock.GetReposGitTreesByOwnerByRepoByTreeSha.Pattern: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+				GetReposByOwnerByRepo: mockResponse(t, http.StatusOK, mockRepo),
+				GetReposGitTreesByOwnerByRepoByTree: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					w.WriteHeader(http.StatusNotFound)
 					_, _ = w.Write([]byte(`{"message": "Not Found"}`))
 				}),

pkg/github/helper_test.go

@@ -15,6 +15,20 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+// GitHub API endpoint patterns for testing
+// These constants define the URL patterns used in HTTP mocking for tests
+const (
+	// Repository endpoints
+	GetReposByOwnerByRepo = "GET /repos/{owner}/{repo}"
+
+	// Git endpoints
+	GetReposGitTreesByOwnerByRepoByTree = "GET /repos/{owner}/{repo}/git/trees/{tree}"
+
+	// Code scanning endpoints
+	GetReposCodeScanningAlertsByOwnerByRepo              = "GET /repos/{owner}/{repo}/code-scanning/alerts"
+	GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber = "GET /repos/{owner}/{repo}/code-scanning/alerts/{alert_number}"
+)
+
 type expectations struct {
 	path        string
 	queryParams map[string]string