From 86f72fefdc0831d5c1fe1180e700be023d04db71 Mon Sep 17 00:00:00 2001 From: John Ryan Date: Wed, 22 Feb 2023 09:22:16 -0800 Subject: [PATCH 1/2] Disable logging in tests --- packages/go_router/CHANGELOG.md | 4 ++++ packages/go_router/pubspec.yaml | 2 +- packages/go_router/test/go_router_test.dart | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index 5b9c7d4bbd5c..f2b307b65b42 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,3 +1,7 @@ +## 6.0.10 + +- Disable logging in tests + ## 6.0.9 - Fixes deprecation message for `GoRouterState.namedLocation` diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index eddc3552f281..0fbec8080dfc 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 6.0.9 +version: 6.0.10 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22 diff --git a/packages/go_router/test/go_router_test.dart b/packages/go_router/test/go_router_test.dart index fb1dbd71d8e0..4a3a61627f9e 100644 --- a/packages/go_router/test/go_router_test.dart +++ b/packages/go_router/test/go_router_test.dart @@ -18,7 +18,7 @@ import 'package:logging/logging.dart'; import 'test_helpers.dart'; -const bool enableLogs = true; +const bool enableLogs = false; final Logger log = Logger('GoRouter tests'); Future sendPlatformUrl(String url) async { From dfe9672213908c6c98945764c33a468e172ad6ce Mon Sep 17 00:00:00 2001 From: John Ryan Date: Wed, 22 Feb 2023 11:10:25 -0800 Subject: [PATCH 2/2] Revert pubspec and CHANGELOG updates --- packages/go_router/CHANGELOG.md | 4 ---- packages/go_router/pubspec.yaml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index f2b307b65b42..5b9c7d4bbd5c 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,7 +1,3 @@ -## 6.0.10 - -- Disable logging in tests - ## 6.0.9 - Fixes deprecation message for `GoRouterState.namedLocation` diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index 0fbec8080dfc..eddc3552f281 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 6.0.10 +version: 6.0.9 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22