From 95441934a86bf1d099e05b4ea129ce0f859073a9 Mon Sep 17 00:00:00 2001 From: skia-flutter-autoroll Date: Wed, 8 Nov 2023 15:09:43 +0000 Subject: [PATCH 1/3] Roll Dart SDK from 15c286ed91ea to 14933042494d (5 revisions) https://dart.googlesource.com/sdk.git/+log/15c286ed91ea..14933042494d 2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-107.0.dev 2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-106.0.dev 2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-105.0.dev 2023-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-104.0.dev 2023-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-103.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --- DEPS | 2 +- ci/licenses_golden/excluded_files | 14 +++--- ci/licenses_golden/licenses_dart | 82 +++++++++++++++---------------- 3 files changed, 49 insertions(+), 49 deletions(-) diff --git a/DEPS b/DEPS index 1be6ea81a6cc1..3191c677e62e9 100644 --- a/DEPS +++ b/DEPS @@ -59,7 +59,7 @@ vars = { # Dart is: https://github.com/dart-lang/sdk/blob/main/DEPS # You can use //tools/dart/create_updated_flutter_deps.py to produce # updated revision list of existing dependencies. - 'dart_revision': '15c286ed91eabd3a252e80abf838e136dcd4e6db', + 'dart_revision': '14933042494d865e9ccb0453433036e03b6da753', # WARNING: DO NOT EDIT MANUALLY # The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py diff --git a/ci/licenses_golden/excluded_files b/ci/licenses_golden/excluded_files index 18a25c8d4ed05..347e3ff92b492 100644 --- a/ci/licenses_golden/excluded_files +++ b/ci/licenses_golden/excluded_files @@ -1812,13 +1812,6 @@ ../../../third_party/dart/runtime/observatory/update_sources.py ../../../third_party/dart/runtime/observatory/web/third_party/README.md ../../../third_party/dart/runtime/tests -../../../third_party/dart/runtime/third_party/binary_size -../../../third_party/dart/runtime/third_party/d3 -../../../third_party/dart/runtime/third_party/double-conversion/.gitignore -../../../third_party/dart/runtime/third_party/double-conversion/AUTHORS -../../../third_party/dart/runtime/third_party/double-conversion/Changelog -../../../third_party/dart/runtime/third_party/double-conversion/README.dart -../../../third_party/dart/runtime/third_party/double-conversion/README.md ../../../third_party/dart/runtime/tools/.gitignore ../../../third_party/dart/runtime/tools/android_finder.py ../../../third_party/dart/runtime/tools/benchmark.py @@ -2019,10 +2012,17 @@ ../../../third_party/dart/tests ../../../third_party/dart/third_party/.gitignore ../../../third_party/dart/third_party/OWNERS +../../../third_party/dart/third_party/binary_size ../../../third_party/dart/third_party/binaryen ../../../third_party/dart/third_party/clang.tar.gz.sha1 +../../../third_party/dart/third_party/d3 ../../../third_party/dart/third_party/d8 ../../../third_party/dart/third_party/devtools +../../../third_party/dart/third_party/double-conversion/.gitignore +../../../third_party/dart/third_party/double-conversion/AUTHORS +../../../third_party/dart/third_party/double-conversion/Changelog +../../../third_party/dart/third_party/double-conversion/README.dart +../../../third_party/dart/third_party/double-conversion/README.md ../../../third_party/dart/third_party/firefox_jsshell ../../../third_party/dart/third_party/mdn/browser-compat-data/README.google ../../../third_party/dart/third_party/pkg diff --git a/ci/licenses_golden/licenses_dart b/ci/licenses_golden/licenses_dart index 53257148c5cc2..0bd6706b6eabd 100644 --- a/ci/licenses_golden/licenses_dart +++ b/ci/licenses_golden/licenses_dart @@ -1,4 +1,4 @@ -Signature: a88142098930724810ab7906133411fb +Signature: 047b7f77486eacf59112b120ba54ac1d ==================================================================================================== LIBRARY: dart @@ -4134,9 +4134,9 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ==================================================================================================== LIBRARY: double-conversion -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/cached-powers.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/cached-powers.cc TYPE: LicenseType.bsd -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/cached-powers.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/cached-powers.cc ---------------------------------------------------------------------------------------------------- Copyright 2006-2008 the V8 project authors. All rights reserved. @@ -4169,35 +4169,35 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ==================================================================================================== LIBRARY: double-conversion -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum-dtoa.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum-dtoa.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/cached-powers.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/diy-fp.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/double-to-string.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/fast-dtoa.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/fixed-dtoa.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/fixed-dtoa.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/string-to-double.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/strtod.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/strtod.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/utils.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/bignum-dtoa.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/bignum-dtoa.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/bignum.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/bignum.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/cached-powers.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/diy-fp.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/double-to-string.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/fast-dtoa.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/fixed-dtoa.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/fixed-dtoa.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/string-to-double.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/strtod.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/strtod.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/utils.h TYPE: LicenseType.bsd -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum-dtoa.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum-dtoa.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/bignum.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/cached-powers.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/diy-fp.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/double-to-string.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/fast-dtoa.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/fixed-dtoa.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/fixed-dtoa.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/string-to-double.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/strtod.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/strtod.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/utils.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/bignum-dtoa.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/bignum-dtoa.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/bignum.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/bignum.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/cached-powers.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/diy-fp.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/double-to-string.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/fast-dtoa.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/fixed-dtoa.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/fixed-dtoa.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/string-to-double.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/strtod.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/strtod.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/utils.h ---------------------------------------------------------------------------------------------------- Copyright 2010 the V8 project authors. All rights reserved. @@ -4230,17 +4230,17 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ==================================================================================================== LIBRARY: double-conversion -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/double-conversion.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/double-to-string.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/fast-dtoa.cc -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/ieee.h -ORIGIN: ../../../third_party/dart/runtime/third_party/double-conversion/src/string-to-double.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/double-conversion.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/double-to-string.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/fast-dtoa.cc +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/ieee.h +ORIGIN: ../../../third_party/dart/third_party/double-conversion/src/string-to-double.h TYPE: LicenseType.bsd -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/double-conversion.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/double-to-string.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/fast-dtoa.cc -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/ieee.h -FILE: ../../../third_party/dart/runtime/third_party/double-conversion/src/string-to-double.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/double-conversion.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/double-to-string.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/fast-dtoa.cc +FILE: ../../../third_party/dart/third_party/double-conversion/src/ieee.h +FILE: ../../../third_party/dart/third_party/double-conversion/src/string-to-double.h ---------------------------------------------------------------------------------------------------- Copyright 2012 the V8 project authors. All rights reserved. From d76989a3967b8e843f9f28542340579cce2ea0f9 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Wed, 8 Nov 2023 08:42:32 -0800 Subject: [PATCH 2/3] Fix double-conversion.h new location coming on a dart roll --- third_party/accessibility/base/string_utils.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/accessibility/base/string_utils.cc b/third_party/accessibility/base/string_utils.cc index 963f7d581d4f7..03c67ee007746 100644 --- a/third_party/accessibility/base/string_utils.cc +++ b/third_party/accessibility/base/string_utils.cc @@ -12,7 +12,7 @@ #include #include "flutter/fml/string_conversion.h" -#include "third_party/dart/runtime/third_party/double-conversion/src/double-conversion.h" +#include "third_party/dart/third_party/double-conversion/src/double-conversion.h" #include "no_destructor.h" From 9c2f167b32015151ad0f0c8554b91f886a4c5908 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Wed, 8 Nov 2023 08:50:09 -0800 Subject: [PATCH 3/3] Update reference to double-conversion itself --- third_party/accessibility/base/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/accessibility/base/BUILD.gn b/third_party/accessibility/base/BUILD.gn index 54b0a47af32ef..673fda743487f 100644 --- a/third_party/accessibility/base/BUILD.gn +++ b/third_party/accessibility/base/BUILD.gn @@ -52,6 +52,6 @@ source_set("base") { "numerics", "//flutter/fml:string_conversion", "//flutter/third_party/accessibility/ax_build", - "//third_party/dart/runtime/third_party/double-conversion/src:libdouble_conversion", + "//third_party/dart/third_party/double-conversion/src:libdouble_conversion", ] }