From f8f91fd365cf548c8bcfa036871847cbef573ae6 Mon Sep 17 00:00:00 2001 From: szymonrybczak Date: Wed, 22 May 2024 01:50:28 +0200 Subject: [PATCH 1/2] fix: warn only in `init` command when CLI uses cached `npx` version --- packages/react-native/cli.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/react-native/cli.js b/packages/react-native/cli.js index 28c17f96a0656b..a08fba5f5d5997 100755 --- a/packages/react-native/cli.js +++ b/packages/react-native/cli.js @@ -29,6 +29,7 @@ let cli = { }; const isNpxRuntime = process.env.npm_lifecycle_event === 'npx'; +const isInitCommand = process.argv[2] === 'init'; const DEFAULT_REGISTRY_HOST = process.env.npm_config_registry ?? 'https://registry.npmjs.org/'; const HEAD = '1000.0.0'; @@ -65,7 +66,7 @@ async function getLatestVersion(registryHost = DEFAULT_REGISTRY_HOST) { * @see https://github.com/react-native-community/discussions-and-proposals/tree/main/proposals/0759-react-native-frameworks.md */ function warnWhenRunningInit() { - if (process.argv[2] === 'init') { + if (isInitCommand) { console.warn( `\nRunning: ${chalk.grey.bold('npx @react-native-community/cli init')}\n`, ); @@ -80,7 +81,7 @@ function warnWhenRunningInit() { * @see https://github.com/react-native-community/discussions-and-proposals/tree/main/proposals/0759-react-native-frameworks.md */ function warnWithDeprecationSchedule() { - if (process.argv[2] !== 'init') { + if (!isInitCommand) { return; } @@ -127,7 +128,7 @@ ${chalk.yellow('⚠')}️ The \`init\` command is deprecated. * */ async function main() { - if (isNpxRuntime && !process.env.SKIP && currentVersion !== HEAD) { + if (isNpxRuntime && !process.env.SKIP && currentVersion !== HEAD && isInitCommand) { try { const latest = await getLatestVersion(); // TODO: T184416093 When cli is deprecated, remove semver from package.json From b7b07864a9bca079ab23890810fb37d012dbbcde Mon Sep 17 00:00:00 2001 From: szymonrybczak Date: Wed, 22 May 2024 18:44:41 +0200 Subject: [PATCH 2/2] chore: lint --- packages/react-native/cli.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/react-native/cli.js b/packages/react-native/cli.js index a08fba5f5d5997..416bd2775590c6 100755 --- a/packages/react-native/cli.js +++ b/packages/react-native/cli.js @@ -128,7 +128,12 @@ ${chalk.yellow('⚠')}️ The \`init\` command is deprecated. * */ async function main() { - if (isNpxRuntime && !process.env.SKIP && currentVersion !== HEAD && isInitCommand) { + if ( + isNpxRuntime && + !process.env.SKIP && + currentVersion !== HEAD && + isInitCommand + ) { try { const latest = await getLatestVersion(); // TODO: T184416093 When cli is deprecated, remove semver from package.json