From 7351b033cc254e52bebf7c50912508856b1170e6 Mon Sep 17 00:00:00 2001 From: Mil4n0r Date: Thu, 19 Sep 2024 15:41:08 +0200 Subject: [PATCH 1/2] Fixed Badge typing for 'label' --- apps/website/screens/components/badge/code/BadgeCodePage.tsx | 2 +- packages/lib/src/badge/Badge.tsx | 2 +- packages/lib/src/badge/types.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/website/screens/components/badge/code/BadgeCodePage.tsx b/apps/website/screens/components/badge/code/BadgeCodePage.tsx index 5d9661364c..5abdee2e3c 100644 --- a/apps/website/screens/components/badge/code/BadgeCodePage.tsx +++ b/apps/website/screens/components/badge/code/BadgeCodePage.tsx @@ -22,7 +22,7 @@ const sections = [ label - string + string | number Text to be placed in the badge. - diff --git a/packages/lib/src/badge/Badge.tsx b/packages/lib/src/badge/Badge.tsx index 937c421ab6..f904943904 100644 --- a/packages/lib/src/badge/Badge.tsx +++ b/packages/lib/src/badge/Badge.tsx @@ -84,7 +84,7 @@ const Label = ({ label, notificationLimit, size }) => { }; const DxcBadge = ({ - label, + label = "", title, mode = "contextual", color = "grey", diff --git a/packages/lib/src/badge/types.tsx b/packages/lib/src/badge/types.tsx index e956be8e39..f893dc73e2 100644 --- a/packages/lib/src/badge/types.tsx +++ b/packages/lib/src/badge/types.tsx @@ -23,7 +23,7 @@ export type NotificationProps = { /** * Text to be placed in the badge. */ - label?: number; + label: number | ""; /** * The available badge modes. */ From 67fb0e787f57afcff81e10569137618b585d5ae7 Mon Sep 17 00:00:00 2001 From: Mil4n0r Date: Fri, 20 Sep 2024 11:24:39 +0200 Subject: [PATCH 2/2] Restored previous label type --- packages/lib/src/badge/Badge.tsx | 2 +- packages/lib/src/badge/types.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/lib/src/badge/Badge.tsx b/packages/lib/src/badge/Badge.tsx index f904943904..937c421ab6 100644 --- a/packages/lib/src/badge/Badge.tsx +++ b/packages/lib/src/badge/Badge.tsx @@ -84,7 +84,7 @@ const Label = ({ label, notificationLimit, size }) => { }; const DxcBadge = ({ - label = "", + label, title, mode = "contextual", color = "grey", diff --git a/packages/lib/src/badge/types.tsx b/packages/lib/src/badge/types.tsx index f893dc73e2..e956be8e39 100644 --- a/packages/lib/src/badge/types.tsx +++ b/packages/lib/src/badge/types.tsx @@ -23,7 +23,7 @@ export type NotificationProps = { /** * Text to be placed in the badge. */ - label: number | ""; + label?: number; /** * The available badge modes. */