diff --git a/src/libraries/System.Private.CoreLib/src/System/Buffer.cs b/src/libraries/System.Private.CoreLib/src/System/Buffer.cs index 543bf79beba7ef..24f8794d852afd 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Buffer.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Buffer.cs @@ -185,7 +185,6 @@ internal static void BulkMoveWithWriteBarrier(ref byte destination, ref byte sou _BulkMoveWithWriteBarrier(ref destination, ref source, byteCount); } -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 // Non-inlinable wrapper around the loop for copying large blocks in chunks [MethodImpl(MethodImplOptions.NoInlining)] private static void _BulkMoveWithWriteBarrier(ref byte destination, ref byte source, nuint byteCount) @@ -220,7 +219,6 @@ private static void _BulkMoveWithWriteBarrier(ref byte destination, ref byte sou } __BulkMoveWithWriteBarrier(ref destination, ref source, byteCount); } -#pragma warning restore IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 #endif // !MONO } diff --git a/src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs b/src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs index ffef2df0989b0e..b182d42b66ecd9 100644 --- a/src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs +++ b/src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs @@ -120,7 +120,6 @@ public ReadOnlySpan(ref readonly T reference) _length = 1; } -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 // Constructor for internal use only. It is not safe to expose publicly, and is instead exposed via the unsafe MemoryMarshal.CreateReadOnlySpan. [MethodImpl(MethodImplOptions.AggressiveInlining)] internal ReadOnlySpan(ref T reference, int length) @@ -130,7 +129,6 @@ internal ReadOnlySpan(ref T reference, int length) _reference = ref reference; _length = length; } -#pragma warning restore IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 /// /// Returns the specified element of the read-only span. diff --git a/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs b/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs index 2fc9946f03803b..0b0da448e4eba9 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs @@ -87,7 +87,6 @@ public static Memory AsMemory(ReadOnlyMemory memory) => /// public static ref T GetReference(ReadOnlySpan span) => ref span._reference; -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 /// /// Returns a reference to the 0th element of the Span. If the Span is empty, returns a reference to fake non-null pointer. Such a reference can be used /// for pinning but must never be dereferenced. This is useful for interop with methods that do not accept null pointers for zero-sized buffers. @@ -101,7 +100,6 @@ public static Memory AsMemory(ReadOnlyMemory memory) => /// [MethodImpl(MethodImplOptions.AggressiveInlining)] internal static unsafe ref T GetNonNullPinnableReference(ReadOnlySpan span) => ref (span.Length != 0) ? ref Unsafe.AsRef(in span._reference) : ref Unsafe.AsRef((void*)1); -#pragma warning restore IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 /// /// Casts a Span of one primitive type to another primitive type . diff --git a/src/libraries/System.Private.CoreLib/src/System/SearchValues/IndexOfAnyAsciiSearcher.cs b/src/libraries/System.Private.CoreLib/src/System/SearchValues/IndexOfAnyAsciiSearcher.cs index bc8b3fd0c6c8f4..deccdddb8feced 100644 --- a/src/libraries/System.Private.CoreLib/src/System/SearchValues/IndexOfAnyAsciiSearcher.cs +++ b/src/libraries/System.Private.CoreLib/src/System/SearchValues/IndexOfAnyAsciiSearcher.cs @@ -10,7 +10,6 @@ using System.Runtime.Intrinsics.X86; #pragma warning disable 8500 // sizeof of managed types -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 namespace System.Buffers { diff --git a/src/libraries/System.Private.CoreLib/src/System/SearchValues/ProbabilisticMap.cs b/src/libraries/System.Private.CoreLib/src/System/SearchValues/ProbabilisticMap.cs index 150372914d8b2e..076340bebebad9 100644 --- a/src/libraries/System.Private.CoreLib/src/System/SearchValues/ProbabilisticMap.cs +++ b/src/libraries/System.Private.CoreLib/src/System/SearchValues/ProbabilisticMap.cs @@ -10,7 +10,6 @@ using System.Runtime.Intrinsics.Wasm; using System.Runtime.Intrinsics.X86; -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 namespace System.Buffers { diff --git a/src/libraries/System.Private.CoreLib/src/System/Span.cs b/src/libraries/System.Private.CoreLib/src/System/Span.cs index 1c66a341b0fde1..38b94e872b0cb3 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Span.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Span.cs @@ -126,7 +126,6 @@ public Span(ref T reference) _length = 1; } -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 // Constructor for internal use only. It is not safe to expose publicly, and is instead exposed via the unsafe MemoryMarshal.CreateSpan. [MethodImpl(MethodImplOptions.AggressiveInlining)] internal Span(ref T reference, int length) @@ -136,7 +135,6 @@ internal Span(ref T reference, int length) _reference = ref reference; _length = length; } -#pragma warning restore IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 /// /// Returns a reference to specified element of the Span. diff --git a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Packed.cs b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Packed.cs index 69ce8c1f7fada9..37f90c695090c2 100644 --- a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Packed.cs +++ b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Packed.cs @@ -7,7 +7,6 @@ using System.Runtime.Intrinsics; using System.Runtime.Intrinsics.X86; -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 #pragma warning disable 8500 // sizeof of managed types diff --git a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs index ed66759fd0bda9..ee378b7646b5cb 100644 --- a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs +++ b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs @@ -8,7 +8,6 @@ using System.Runtime.InteropServices; using System.Runtime.Intrinsics; -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 #pragma warning disable 8500 // sizeof of managed types diff --git a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.cs b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.cs index aa7ed473d9feff..b770e55cae4fde 100644 --- a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.cs +++ b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.cs @@ -329,7 +329,6 @@ public static unsafe void Reverse(ref T elements, nuint length) ReverseInner(ref elements, length); } -#pragma warning disable IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 [MethodImpl(MethodImplOptions.AggressiveInlining)] private static void ReverseInner(ref T elements, nuint length) { @@ -346,6 +345,5 @@ private static void ReverseInner(ref T elements, nuint length) last = ref Unsafe.Subtract(ref last, 1); } while (Unsafe.IsAddressLessThan(ref first, ref last)); } -#pragma warning restore IDE0060 // https://github.com/dotnet/roslyn-analyzers/issues/6228 } }