From 13793c6a4be99c93b51c4cbd437ec12e0b9204f3 Mon Sep 17 00:00:00 2001 From: milanmajchrak Date: Mon, 16 Jun 2025 18:18:41 +0200 Subject: [PATCH 1/2] The hasPreview method has been changed, but the IT wasn't updated correctly --- .../org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java b/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java index 52c93c80de59..d00ea7f0b4c2 100644 --- a/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java +++ b/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java @@ -11,6 +11,7 @@ import static org.hamcrest.Matchers.hasItem; import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.notNullValue; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content; @@ -173,7 +174,7 @@ public void previewingIsDisabledByCfg() throws Exception { .value(Matchers.containsInAnyOrder(Matchers.containsString(bts.getChecksum())))) .andExpect(jsonPath("$._embedded.metadatabitstreams[*].href") .value(Matchers.containsInAnyOrder(Matchers.containsString(url)))); - assertTrue(previewContentService.hasPreview(context, bts).isEmpty()); + assertFalse(previewContentService.hasPreview(context, bts)); configurationService.setProperty("file.preview.enabled", canPreview); context.restoreAuthSystemState(); } From e8da5216dba3d08dc963b0918c2594e7557a77aa Mon Sep 17 00:00:00 2001 From: milanmajchrak Date: Mon, 16 Jun 2025 18:20:45 +0200 Subject: [PATCH 2/2] Fixed checkstyle violation --- .../org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java | 1 - 1 file changed, 1 deletion(-) diff --git a/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java b/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java index d00ea7f0b4c2..11fc3ea123ad 100644 --- a/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java +++ b/dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadataBitstreamRestRepositoryIT.java @@ -12,7 +12,6 @@ import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.notNullValue; import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;