Skip to content

Commit f3294f7

Browse files
askeksacommit-bot@chromium.org
authored andcommitted
[cfe] Ignore context when de-duplicating error messages
Change-Id: I44b00ca5277f69fdaa05bb71a5409ea9dabac601 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121061 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Aske Simon Christensen <askesc@google.com>
1 parent ed1e0e1 commit f3294f7

File tree

3 files changed

+0
-19
lines changed

3 files changed

+0
-19
lines changed

pkg/front_end/lib/src/fasta/loader.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -314,17 +314,6 @@ charOffset: $charOffset
314314
fileUri: $fileUri
315315
severity: $severity
316316
""";
317-
// TODO(askesc): Swap message and context around for interface checks
318-
// and mixin overrides to make comparing context here unnecessary.
319-
if (context != null) {
320-
for (LocatedMessage contextMessage in context) {
321-
trace += """
322-
message: ${contextMessage.message}
323-
charOffset: ${contextMessage.charOffset}
324-
fileUri: ${contextMessage.uri}
325-
""";
326-
}
327-
}
328317
if (!seenMessages.add(trace)) return null;
329318
if (message.code.severity == Severity.context) {
330319
internalProblem(

pkg/front_end/testcases/general/duplicated_declarations.dart.outline.expect

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,6 @@ library;
306306
// class Sub extends C {
307307
// ^
308308
//
309-
// pkg/front_end/testcases/general/duplicated_declarations.dart:65:19: Error: 'C' isn't a type.
310-
// class Sub extends C {
311-
// ^
312-
//
313309
import self as self;
314310
import "dart:core" as core;
315311

pkg/front_end/testcases/general/duplicated_declarations.dart.strong.expect

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,6 @@ library;
306306
// class Sub extends C {
307307
// ^
308308
//
309-
// pkg/front_end/testcases/general/duplicated_declarations.dart:65:19: Error: 'C' isn't a type.
310-
// class Sub extends C {
311-
// ^
312-
//
313309
// pkg/front_end/testcases/general/duplicated_declarations.dart:34:3: Error: Can't use 'main' because it is declared more than once.
314310
// main();
315311
// ^

0 commit comments

Comments
 (0)