Skip to content

Commit 269f486

Browse files
bulk: avoid spamming log file when requests have already
been cleared due to auto-clear flag Motivation: ---------- checkTerminated method generates excessive log due to exception caught when request is not found. This happens all the time if auto-clear is set to true. Modification: ------------- Catch and ignore BulkRequestNotFoundException when retrieving request by ID Result: ------- Less verbose output in the log file Ticket: #7931 Acked-by: Target: trunk Request: 11.1 11.0 10.2 10.1 10.0 9.2 Require-book: no Require-notes: yes Patch: https://rb.dcache.org/r/14577/ Acked-by: Tigran
1 parent 2fbffb3 commit 269f486

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

modules/dcache-bulk/src/main/java/org/dcache/services/bulk/handler/BulkRequestHandler.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,11 @@ public boolean checkTerminated(String id, boolean cancelled) {
171171
}
172172
});
173173
}
174+
} catch (BulkRequestNotFoundException e) {
175+
/*
176+
* Request has been cleared already.
177+
*/
178+
LOGGER.debug("checkTerminated, request {} was auto-cleared on termination.", id);
174179
} catch (BulkStorageException e) {
175180
LOGGER.warn("checkTerminated, check for cancel on failure {}: {}.", id,
176181
e.toString());

0 commit comments

Comments
 (0)