add -b or --fqbn completion for the monitor command and tests

Author: umbynos

cli/monitor/monitor.go

@@ -61,6 +61,9 @@ func NewCommand() *cobra.Command {
 	cmd.Flags().StringSliceVarP(&configs, "config", "c", []string{}, tr("Configuration of the port."))
 	cmd.Flags().BoolVarP(&quiet, "quiet", "q", false, tr("Run in silent mode, show only monitor input and output."))
 	cmd.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))
+	cmd.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		return arguments.GetInstalledBoards(), cobra.ShellCompDirectiveDefault
+	})
 	cmd.MarkFlagRequired("port")
 	return cmd
 }

i18n/data/en.po

@@ -427,7 +427,7 @@ msgstr "Configuring platform."
 msgid "Connected"
 msgstr "Connected"
 
-#: cli/monitor/monitor.go:174
+#: cli/monitor/monitor.go:177
 msgid "Connected to %s! Press CTRL-C to exit."
 msgstr "Connected to %s! Press CTRL-C to exit."
 
@@ -504,7 +504,7 @@ msgstr "Debugging not supported for board %s"
 msgid "Debugging supported:"
 msgstr "Debugging supported:"
 
-#: cli/monitor/monitor.go:192
+#: cli/monitor/monitor.go:195
 msgid "Default"
 msgstr "Default"
 
@@ -790,7 +790,7 @@ msgstr "Error getting information for library %s"
 msgid "Error getting libraries info: %v"
 msgstr "Error getting libraries info: %v"
 
-#: cli/monitor/monitor.go:87
+#: cli/monitor/monitor.go:90
 msgid "Error getting port settings details: %s"
 msgstr "Error getting port settings details: %s"
 
@@ -1139,7 +1139,7 @@ msgstr "Global variables use {0} bytes of dynamic memory."
 
 #: cli/core/list.go:84
 #: cli/core/search.go:114
-#: cli/monitor/monitor.go:192
+#: cli/monitor/monitor.go:195
 #: cli/outdated/outdated.go:62
 msgid "ID"
 msgstr "ID"
@@ -1480,7 +1480,7 @@ msgstr "Missing sketch path"
 msgid "Monitor '%s' not found"
 msgstr "Monitor '%s' not found"
 
-#: cli/monitor/monitor.go:140
+#: cli/monitor/monitor.go:143
 msgid "Monitor port settings:"
 msgstr "Monitor port settings:"
 
@@ -1736,8 +1736,8 @@ msgstr "Platform size (bytes):"
 msgid "Port"
 msgstr "Port"
 
-#: cli/monitor/monitor.go:161
-#: cli/monitor/monitor.go:168
+#: cli/monitor/monitor.go:164
+#: cli/monitor/monitor.go:171
 msgid "Port closed:"
 msgstr "Port closed:"
 
@@ -1878,7 +1878,7 @@ msgstr "Sets a setting value."
 msgid "Sets where to save the configuration file."
 msgstr "Sets where to save the configuration file."
 
-#: cli/monitor/monitor.go:192
+#: cli/monitor/monitor.go:195
 msgid "Setting"
 msgstr "Setting"
 
@@ -2353,7 +2353,7 @@ msgstr "VERSION"
 msgid "VERSION_NUMBER"
 msgstr "VERSION_NUMBER"
 
-#: cli/monitor/monitor.go:192
+#: cli/monitor/monitor.go:195
 msgid "Values"
 msgstr "Values"
 
@@ -2860,11 +2860,11 @@ msgstr "invalid platform archive size: %s"
 msgid "invalid pluggable monitor reference: %s"
 msgstr "invalid pluggable monitor reference: %s"
 
-#: cli/monitor/monitor.go:123
+#: cli/monitor/monitor.go:126
 msgid "invalid port configuration value for %s: %s"
 msgstr "invalid port configuration value for %s: %s"
 
-#: cli/monitor/monitor.go:132
+#: cli/monitor/monitor.go:135
 msgid "invalid port configuration: %s"
 msgstr "invalid port configuration: %s"
 

test/test_completion.py

@@ -179,6 +179,8 @@ def test_core_completion(run_command):
     assert "arduino:avr:uno" in result.stdout
     result = run_command(["__complete", "upload", "-b", ""])
     assert "arduino:avr:uno" in result.stdout
+    result = run_command(["__complete", "monitor", "-b", ""])
+    assert "arduino:avr:uno" in result.stdout
     result = run_command(["__complete", "burn-bootloader", "-l", ""])
     assert "network" in result.stdout
     result = run_command(["__complete", "compile", "-l", ""])
@@ -187,6 +189,8 @@ def test_core_completion(run_command):
     assert "network" in result.stdout
     result = run_command(["__complete", "upload", "-l", ""])
     assert "network" in result.stdout
+    result = run_command(["__complete", "monitor", "-l", ""])
+    assert "network" in result.stdout
     result = run_command(["__complete", "burn-bootloader", "-P", ""])
     assert "atmel_ice" in result.stdout
     result = run_command(["__complete", "compile", "-P", ""])