Skip to content

Fix Grid bugs #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TorstenDittmann merged 4 commits into from
Nov 6, 2023
Merged

Fix Grid bugs #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5672895
Fix Grid bugs
elad2412 Oct 31, 2023
e6a6a77
Hide go to console button on mobile
elad2412 Oct 31, 2023
c879bcb
Remove go to console button from top navigation in mobile
elad2412 Oct 31, 2023
22b1a5e
Delete added same variables of Thomas
elad2412 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/layouts/Docs.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
</a>
</div>
<div class="aw-mobile-header-end">
<a href="https://cloud.appwrite.io/console" class="aw-button">
<a href="https://cloud.appwrite.io/console" class="aw-button is-not-mobile">
<span class="aw-sub-body-500">Go to console</span>
</a>
<button on:click={toggleSidenav} class="aw-button is-text" aria-label="open navigation">
Expand Down
13 changes: 1 addition & 12 deletions src/scss/1-css-variables/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,20 +105,9 @@
#{$theme-dark} { @include color-dark; }
}

.#{$p}-u-color-text-primary { color:hsl(var(--aw-color-primary))!important; }
.#{$p}-clr-primary { color:hsl(var(--aw-color-primary))!important; }

.#{$p}-u-color-text-primary { color:hsl(var(--aw-color-primary))!important; }
.#{$p}-u-color-text-secondary { color:hsl(var(--aw-color-secondary))!important; }
.#{$p}-clr-secondary { color:hsl(var(--aw-color-secondary))!important; }

.#{$p}-u-color-text-tertiary { color:hsl(var(--aw-color-tertiary))!important; }
.#{$p}-clr-tertiary { color:hsl(var(--aw-color-tertiary))!important; }

.#{$p}-u-color-text-accent { -webkit-text-fill-color: hsl(var(--aw-color-accent))!important; color:hsl(var(--aw-color-accent))!important; }
.#{$p}-clr-accent { -webkit-text-fill-color: hsl(var(--aw-color-accent))!important; color:hsl(var(--aw-color-accent))!important; }

.#{$p}-u-color-text-accent-darker { color:hsl(var(--aw-color-accent-darker))!important; }
.#{$p}-clr-accent-darker { color:hsl(var(--aw-color-accent-darker))!important; }

.#{$p}-u-color-text-accent-click { color:hsl(var(--aw-color-accent-click))!important; }
.#{$p}-clr-accent-click { color:hsl(var(--aw-color-accent-click))!important; }
2 changes: 1 addition & 1 deletion src/scss/7-components/_mobile-header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
position:sticky; z-index:20; inset-block-start:0; background-color:hsl(var(--p-body-bg-color));
display:flex; justify-content:space-between; align-items:center; gap:pxToRem(16);
border-block-end: solid 1px var(--p-mobile-header-border-color);
padding:pxToRem(20);
padding-inline:pxToRem(20); padding-block:pxToRem(16);
&-start { display:flex; align-items: center; }
&-end { display:flex; align-items: center; gap: pxToRem(8) }
&.is-transparent { background-color:transparent; -webkit-backdrop-filter:blur(pxToRem(8)); backdrop-filter:blur(pxToRem(8)); }
Expand Down
6 changes: 4 additions & 2 deletions src/scss/7-components/_side-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@


position:sticky; z-index:35; inset-block-start:pxToRem(74); inset-block-end:0;
block-size:calc(100vh - pxToRem(160)); block-size:calc(100dvh - pxToRem(81));
block-size:calc(100vh - pxToRem(160)); block-size:calc(100dvh - pxToRem(73));
.#{$p}-icon-button { transition:var(--transition); margin-block-end:pxToRem(-4); margin-inline-end:pxToRem(6); }


Expand All @@ -29,8 +29,10 @@
background-color:hsl(var(--p-side-nav-bg-color)); transition:var(--transition);

&-parent {
position:sticky; inset-block-start:pxToRem(-16); background-color:hsl(var(--p-body-bg-color));
display:flex; align-items:center;
padding-block-end:pxToRem(16); border-block-end:pxToRem(1) solid hsl(var(--aw-color-smooth));
padding-block:pxToRem(16); margin-block-start:pxToRem(-16);
border-block-end:pxToRem(1) solid hsl(var(--aw-color-smooth));
[class*="icon"]:first-child { flex-shrink:0; padding-inline:pxToRem(12); }
&-title { @include trim(1); inline-size:100%; margin-inline-end:pxToRem(44); text-align:center; transition:var(--transition); }
}
Expand Down
15 changes: 12 additions & 3 deletions src/scss/9-grids/_grid-huge-navs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
.#{$p}-article {
&-header {
block-size:var(--p-grid-huge-navs-secondary-header-height);
padding-inline-end:var(--p-grid-huge-navs-padding-inline);
margin-inline-start:var(--p-grid-huge-navs-padding-inline);
inset-block-start:var(--p-grid-huge-navs-main-header-height);
//&::after {
Expand All @@ -91,9 +92,8 @@
}
&-content { padding-inline:var(--p-grid-huge-navs-padding-inline); }
}
.#{$p}-references-menu { border-inline-start:solid pxToRem(1) hsl(var(--aw-color-border)); }

.#{$p}-references-menu {
border-inline-start:solid pxToRem(1) hsl(var(--aw-color-border));
&-content { position:sticky; inset-block-start:var(--p-grid-huge-navs-secondary-sticky-position); }
}
}
Expand Down Expand Up @@ -145,6 +145,15 @@
}
}
@media #{$break6open} {
.#{$p}-side-nav { inline-size:var(--p-grid-huge-navs-side-nav-width-opened); }
.#{$p}-side-nav {
inline-size:var(--p-grid-huge-navs-side-nav-width-opened);
&-wrapper { padding-block:0; }
&-scroll { padding-block:pxToRem(16); }
}
.#{$p}-article {
&-header {
padding-inline-end: 0;
}
}
}
}
8 changes: 6 additions & 2 deletions src/scss/9-grids/_grid-side-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
}
@media #{$break2} {
.#{$p}-side-nav {
display:none; position:fixed; inset-inline-start:0; inset-block:0; background:hsl(var(--aw-color-background));
display:none; position:fixed; inset-inline-start:0; inset-block-start:pxToRem(73); inset-block-end:0; background:hsl(var(--aw-color-background));
inline-size:pxToRem(280); block-size:initial; border-inline-end:solid pxToRem(1) hsl(var(--color-border));
}
&.is-open {
Expand All @@ -40,7 +40,11 @@
display:grid; grid-template-columns: pxToRem(280) minmax(0, 1fr);
grid-template-areas: "header header"
"side main";
.#{$p}-side-nav { border-inline-end:solid pxToRem(1) hsl(var(--color-border));}
.#{$p}-side-nav {
border-inline-end:solid pxToRem(1) hsl(var(--color-border));
&-wrapper { padding-block:0; }
&-scroll { padding-block:pxToRem(16); }
}

}
}
6 changes: 5 additions & 1 deletion src/scss/9-grids/_grid-two-side-navs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@
grid-template-areas: "side-a a-header side-b"
"side-a main side-b"
"side-a footer footer";
.#{$p}-side-nav { inline-size:var(--p-grid-huge-navs-side-nav-width-opened); }
.#{$p}-side-nav {
inline-size:var(--p-grid-huge-navs-side-nav-width-opened);
&-wrapper { padding-block:0; }
&-scroll { padding-block:pxToRem(16); }
}
}
}