ADFA-1724: Fix close plugin tab not working when it's the only open tab

[Daniel-ADFA]

No description provided.

[coderabbitai]

📝 Walkthrough

Release Notes - ADFA-1724: Fix close plugin tab not working when it's the only open tab

• Fixed plugin tab closure: Removed the restriction that prevented users from closing a plugin tab when it was the only open tab, improving flexibility in tab management
• Optimized tab selection: Changed plugin tab creation to conditionally select the tab only if it is not already selected, eliminating redundant re-selection operations

Potential Considerations:

• Behavioral Change: Users may now close all tabs, resulting in an empty editor view. Consider ensuring your UI gracefully handles the case when both file tabs and plugin tabs are empty
• Fragment Lifecycle: When plugin tabs can be closed without restrictions, ensure all plugin fragments properly implement lifecycle management and cleanup to prevent memory leaks or state issues

Walkthrough

The pull request refines plugin tab management in the editor activity. Tab selection during plugin fragment attachment is now conditional, preventing redundant re-selection. The popup display logic is simplified by removing the restriction that prevented showing the popup with a single tab.

Changes

Cohort / File(s)	Summary
Plugin Tab Management app/src/main/java/com/itsaky/androidide/activities/editor/EditorHandlerActivity.kt	Modified tab selection logic to conditionally select tabs only when not already selected, avoiding redundant re-selection. Removed check that blocked popup display when only one tab is open.
Build Configuration build.gradle, build.gradle.kts	Build configuration updates (manifest files).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A hop through tabs, so neat and bright,
No double-selects, just smooth delight,
Pop-ups bloom where one tab stood,
Logic trimmed—refined and good! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess relevance or quality of the explanation.	Add a pull request description explaining the bug, the fix applied, and any testing performed to verify the changes work as intended.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the main fix: enabling plugin tab closure when it's the only open tab, matching the code changes that allow popup display in single-tab scenarios.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ADFA-1724

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hal-eisen-adfa]

LGTM