Skip to content

Commit fb8f350

Browse files
committed
Use verbose variable names
1 parent e68dbb9 commit fb8f350

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

pyiceberg/table/update/__init__.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -470,13 +470,17 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl
470470
@_apply_table_update.register(RemoveSnapshotsUpdate)
471471
def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _TableMetadataUpdateContext) -> TableMetadata:
472472
for remove_snapshot_id in update.snapshot_ids:
473-
if not any(s.snapshot_id == remove_snapshot_id for s in base_metadata.snapshots):
473+
if not any(snapshot.snapshot_id == remove_snapshot_id for snapshot in base_metadata.snapshots):
474474
raise ValueError(f"Snapshot with snapshot id {remove_snapshot_id} does not exist: {base_metadata.snapshots}")
475475

476476
snapshots = [
477-
(s.model_copy(update={"parent_snapshot_id": None}) if s.parent_snapshot_id in update.snapshot_ids else s)
478-
for s in base_metadata.snapshots
479-
if s.snapshot_id not in update.snapshot_ids
477+
(
478+
snapshot.model_copy(update={"parent_snapshot_id": None})
479+
if snapshot.parent_snapshot_id in update.snapshot_ids
480+
else snapshot
481+
)
482+
for snapshot in base_metadata.snapshots
483+
if snapshot.snapshot_id not in update.snapshot_ids
480484
]
481485
snapshot_log = [
482486
snapshot_log_entry
@@ -503,7 +507,6 @@ def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _Tab
503507
return new_metadata.model_copy(update={"snapshots": snapshots, "snapshot_log": snapshot_log})
504508

505509

506-
507510
@_apply_table_update.register(RemoveSnapshotRefUpdate)
508511
def _(update: RemoveSnapshotRefUpdate, base_metadata: TableMetadata, context: _TableMetadataUpdateContext) -> TableMetadata:
509512
if update.ref_name not in base_metadata.refs:

0 commit comments

Comments
 (0)