Skip to content

Commit 0e57e95

Browse files
committed
refactor deleted_data_files
1 parent e3d7f92 commit 0e57e95

File tree

6 files changed

+87
-109
lines changed

6 files changed

+87
-109
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ test-integration:
4242
docker-compose -f dev/docker-compose-integration.yml up -d
4343
sleep 5
4444
docker-compose -f dev/docker-compose-integration.yml exec -T spark-iceberg ipython ./provision.py
45-
poetry run pytest tests/ -v -m france ${PYTEST_ARGS} -s
45+
poetry run pytest tests/ -v -m integration ${PYTEST_ARGS}
4646

4747

4848
test-integration-rebuild:

pyiceberg/expressions/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -664,13 +664,11 @@ class LiteralPredicate(UnboundPredicate[L], ABC):
664664
literal: Literal[L]
665665

666666
def __init__(self, term: Union[str, UnboundTerm[Any]], literal: Union[L, Literal[L]]): # pylint: disable=W0621
667-
# print("lets check the type", literal, type(literal), term)
668667
super().__init__(term)
669668
self.literal = _to_literal(literal) # pylint: disable=W0621
670669

671670
def bind(self, schema: Schema, case_sensitive: bool = True) -> BoundLiteralPredicate[L]:
672671
bound_term = self.term.bind(schema, case_sensitive)
673-
# print("last min", self.term, self.literal, bound_term, bound_term.ref().field, bound_term.ref().field.field_type)
674672
lit = self.literal.to(bound_term.ref().field.field_type)
675673

676674
if isinstance(lit, AboveMax):

pyiceberg/expressions/visitors.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,6 @@ def visit_not_null(self, term: BoundTerm[L]) -> bool:
490490
return term.eval(self.struct) is not None
491491

492492
def visit_equal(self, term: BoundTerm[L], literal: Literal[L]) -> bool:
493-
# print("adrian kernel is called", term, literal, "eval is, ", term.eval(self.struct), f"{self.struct=}")
494493
return term.eval(self.struct) == literal.value
495494

496495
def visit_not_equal(self, term: BoundTerm[L], literal: Literal[L]) -> bool:
@@ -554,8 +553,6 @@ def __init__(self, partition_struct_schema: Schema, partition_filter: BooleanExp
554553
self.partition_filter = bind(partition_struct_schema, rewrite_not(partition_filter), case_sensitive)
555554

556555
def eval(self, manifest: ManifestFile) -> bool:
557-
# print(f"about why partition evalutes failed {manifest.partitions=}")
558-
# print(f"about why partition evalutes failed {manifest.partitions[0].lower_bound=}, {manifest.partitions[0].upper_bound=}, {self.partition_filter=}")
559556
if partitions := manifest.partitions:
560557
self.partition_fields = partitions
561558
return visit(self.partition_filter, self)

0 commit comments

Comments
 (0)