findbugs and PMD fixes

This closes #168

Signed-off-by: Rajani Karuturi <[email protected]>

Author: KC Wang

plugins/network-elements/bigswitch/src/com/cloud/agent/api/BcfAnswer.java

@@ -22,17 +22,17 @@
 public class BcfAnswer extends Answer{
     private final String hash;
 
-    public BcfAnswer(Command command, boolean success, String details) {
+    public BcfAnswer(final Command command, final boolean success, final String details) {
         super(command, success, details);
         this.hash = "";
     }
 
-    public BcfAnswer(Command command, boolean success, String details, String hash) {
+    public BcfAnswer(final Command command, final boolean success, final String details, final String hash) {
         super(command, success, details);
         this.hash = hash;
     }
 
-    public BcfAnswer(Command command, Exception e) {
+    public BcfAnswer(final Command command, final Exception e) {
         super(command, e);
         this.hash = "";
     }

plugins/network-elements/bigswitch/src/com/cloud/agent/api/BcfCommand.java

@@ -22,8 +22,8 @@
 import com.cloud.network.bigswitch.TopologyData;
 
 public class BcfCommand extends Command {
-    private TopologyData topology = null;
-    private boolean _topologySyncRequested = false;
+    private TopologyData topology;
+    private boolean topologySyncRequested;
 
     @Override
     public boolean executeInSequence() {
@@ -34,15 +34,15 @@ public TopologyData getTopology() {
         return topology;
     }
 
-    public void setTopology(TopologyData topology) {
+    public void setTopology(final TopologyData topology) {
         this.topology = topology;
     }
 
-    public boolean is_topologySyncRequested() {
-        return _topologySyncRequested;
+    public boolean isTopologySyncRequested() {
+        return topologySyncRequested;
     }
 
-    public void set_topologySyncRequested(boolean requested) {
-        this._topologySyncRequested = requested;
+    public void setTopologySyncRequested(final boolean requested) {
+        this.topologySyncRequested = requested;
     }
 }

plugins/network-elements/bigswitch/src/com/cloud/agent/api/CacheBcfTopologyCommand.java

@@ -22,10 +22,10 @@
 import com.cloud.network.bigswitch.TopologyData;
 
 public class CacheBcfTopologyCommand extends Command{
-    private final TopologyData topology;
+    private final TopologyData _topology;
 
-    public CacheBcfTopologyCommand(TopologyData topology){
-        this.topology = topology;
+    public CacheBcfTopologyCommand(final TopologyData topology){
+        this._topology = topology;
     }
 
     @Override
@@ -34,6 +34,6 @@ public boolean executeInSequence() {
     }
 
     public TopologyData getTopology() {
-        return topology;
+        return _topology;
     }
 }

plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentCommand.java

@@ -20,18 +20,18 @@
 package com.cloud.agent.api;
 
 public class CreateBcfAttachmentCommand extends BcfCommand {
-    private String _tenantId;
-    private String _tenantName;
-    private String _networkId;
-    private String _portId;
-    private String _nicId;
-    private Integer _vlan;
-    private String _ipv4;
-    private String _mac;
+    private final String _tenantId;
+    private final String _tenantName;
+    private final String _networkId;
+    private final String _portId;
+    private final String _nicId;
+    private final Integer _vlan;
+    private final String _ipv4;
+    private final String _mac;
 
-    public CreateBcfAttachmentCommand(String tenantId, String tenantName,
-            String networkId, String portId, String nicId,
-            Integer vlan, String ipv4, String mac) {
+    public CreateBcfAttachmentCommand(final String tenantId, final String tenantName,
+            final String networkId, final String portId, final String nicId,
+            final Integer vlan, final String ipv4, final String mac) {
         this._tenantId = tenantId;
         this._tenantName = tenantName;
         this._networkId = networkId;

plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfRouterCommand.java

@@ -22,11 +22,11 @@
 public class CreateBcfRouterCommand extends BcfCommand {
     private final String _tenantId;
 
-    public CreateBcfRouterCommand(String tenantId){
+    public CreateBcfRouterCommand(final String tenantId){
         this._tenantId = tenantId;
     }
 
-    public String get_tenantId() {
+    public String getTenantId() {
         return _tenantId;
     }
 }

plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfRouterInterfaceCommand.java

@@ -26,32 +26,32 @@ public class CreateBcfRouterInterfaceCommand extends BcfCommand{
     private final String _gateway;
     private final String _networkName;
 
-    public CreateBcfRouterInterfaceCommand(String tenantId, String networkId, String cidr,
-            String gateway, String networkName){
+    public CreateBcfRouterInterfaceCommand(final String tenantId, final String networkId,
+            final String cidr, final String gateway, final String networkName){
         this._tenantId = tenantId;
         this._networkId = networkId;
         this._networkName = networkName;
         this._cidr = cidr;
         this._gateway = gateway;
     }
 
-    public String get_tenantId() {
+    public String getTenantId() {
         return _tenantId;
     }
 
-    public String get_networkId() {
+    public String getNetworkId() {
         return _networkId;
     }
 
-    public String get_networkName() {
+    public String getNetworkName() {
         return _networkName;
     }
 
-    public String get_cidr() {
+    public String getCidr() {
         return _cidr;
     }
 
-    public String get_gateway() {
+    public String getGateway() {
         return _gateway;
     }
 }

plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentCommand.java

@@ -20,14 +20,14 @@
 package com.cloud.agent.api;
 
 public class CreateBcfSegmentCommand extends BcfCommand {
-    private String _tenantId;
-    private String _tenantName;
-    private String _networkId;
-    private String _networkName;
-    private Integer _vlan;
-
-    public CreateBcfSegmentCommand(String tenantId, String tenantName,
-            String networkId, String networkName, Integer vlan) {
+    private final String _tenantId;
+    private final String _tenantName;
+    private final String _networkId;
+    private final String _networkName;
+    private final Integer _vlan;
+
+    public CreateBcfSegmentCommand(final String tenantId, final String tenantName,
+            final String networkId, final String networkName, final Integer vlan) {
         this._tenantId = tenantId;
         this._tenantName = tenantName;
         this._networkId = networkId;

plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfStaticNatCommand.java

@@ -26,32 +26,32 @@ public class CreateBcfStaticNatCommand extends BcfCommand {
     private final String _publicIp;
     private final String _mac;
 
-    public CreateBcfStaticNatCommand(String tenantId, String networkId,
-            String privateIp, String publicIp, String mac){
+    public CreateBcfStaticNatCommand(final String tenantId, final String networkId,
+            final String privateIp, final String publicIp, final String mac){
         this._tenantId = tenantId;
         this._networkId = networkId;
         this._privateIp = privateIp;
         this._publicIp = publicIp;
         this._mac = mac;
     }
 
-    public String get_tenantId() {
+    public String getTenantId() {
         return _tenantId;
     }
 
-    public String get_networkId() {
+    public String getNetworkId() {
         return _networkId;
     }
 
-    public String get_privateIp() {
+    public String getPrivateIp() {
         return _privateIp;
     }
 
-    public String get_publicIp() {
+    public String getPublicIp() {
         return _publicIp;
     }
 
-    public String get_mac() {
+    public String getMac() {
         return _mac;
     }
 }

plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentCommand.java

@@ -20,12 +20,12 @@
 package com.cloud.agent.api;
 
 public class DeleteBcfAttachmentCommand extends BcfCommand {
-    private String _tenantId;
-    private String _networkId;
-    private String _attachmentId;
+    private final String _tenantId;
+    private final String _networkId;
+    private final String _attachmentId;
 
-    public DeleteBcfAttachmentCommand(String tenantId,
-            String networkId, String attachmentId) {
+    public DeleteBcfAttachmentCommand(final String tenantId,
+            final String networkId, final String attachmentId) {
         this._tenantId = tenantId;
         this._networkId = networkId;
         this._attachmentId = attachmentId;

plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentCommand.java

@@ -21,19 +21,19 @@
 
 public class DeleteBcfSegmentCommand extends BcfCommand {
 
-    private String _tenantUuid;
-    private String _networkUuid;
+    private final String _tenantUuid;
+    private final String _networkUuid;
 
-    public DeleteBcfSegmentCommand(String tenantUuid, String networkUuid) {
+    public DeleteBcfSegmentCommand(final String tenantUuid, final String networkUuid) {
         this._tenantUuid = tenantUuid;
         this._networkUuid = networkUuid;
     }
 
-    public String get_tenantUuid() {
+    public String getTenantUuid() {
         return _tenantUuid;
     }
 
     public String getNetworkUuid() {
         return _networkUuid;
     }
-}
+}