-
Notifications
You must be signed in to change notification settings - Fork 118
Description
destination_choice assigns destination taz for non mandatory tours.
destination is implicitly workplace_taz for work tours and school_taz for school taz, but the destination fields are never set, breaking a bunch of computed columns like dest_topology that are used by the mode_choice_simulate spec - they come up as NaN values resulting in Nan utilities that causes the make_choices call to fail in simple_simulate.
This is not caught in testing as mode_choice_simulate in master only runs tour_type 'eatout' which is a non mandatory tour type and thus has a valid destination.
I am holding on fixing this because it depends on several cascading shortcuts int the current implementation that we will want to address at once, and I don't want to add a fix until first writing a failing test...