From 5349db19195e2bdf96162b3a8c9205380f8e03c1 Mon Sep 17 00:00:00 2001 From: Bret Comnes Date: Tue, 1 Dec 2020 12:18:34 -0700 Subject: [PATCH 1/3] add failing test case for relative * export --- test.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test.js b/test.js index 9bba9a5..5e0dc9a 100644 --- a/test.js +++ b/test.js @@ -65,6 +65,11 @@ const tests = [ esm: `export * from "foo";`, cjs: `(m => Object.keys(m).map(k => k !== 'default' && (exports[k] = m[k])))\n(require("foo"));` }, + { + esm: `export * as commands from './local.js';`, + cjs: `'use strict';\n(m => Object.keys(m).map(k => k !== 'default' && (exports[k] = m[k])))\n(require('./local.js')); +` + }, // imports { esm: `import * as name from "module-name";`, @@ -156,4 +161,4 @@ console.log( ) === `'use strict';\nconst I = require.I(require("test"));\nfunction E() {}\nrequire.E(exports).default = E`, 'both import and export can be overwritten' -); \ No newline at end of file +); From 7a8a8a69a812f29f53ab0afbc723bbdd10d4fed1 Mon Sep 17 00:00:00 2001 From: Bret Comnes Date: Tue, 1 Dec 2020 12:18:56 -0700 Subject: [PATCH 2/3] Add test build step Feel free to revert this if you don't want it. --- package.json | 3 ++- test/source/test.js | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index dd4616c..8e9cdf2 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,8 @@ "main": "index.js", "scripts": { "coveralls": "nyc report --reporter=text-lcov | coveralls", - "test": "nyc node test.js" + "test": "nyc node test.js && npm run test-build", + "test-build": "./bin.js test/source test/dest" }, "repository": { "type": "git", diff --git a/test/source/test.js b/test/source/test.js index fed7b47..0ed2148 100644 --- a/test/source/test.js +++ b/test/source/test.js @@ -1,5 +1,6 @@ import func, {a, b} from './module.js'; import * as tmp from 'other'; +export * as commands from './local.js' console.log(import.meta.url); From 385163eea2358e5cc9468405c5f7a5ba822cccb4 Mon Sep 17 00:00:00 2001 From: Bret Comnes Date: Tue, 1 Dec 2020 12:30:08 -0700 Subject: [PATCH 3/3] typo --- test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test.js b/test.js index 5e0dc9a..7257e39 100644 --- a/test.js +++ b/test.js @@ -67,8 +67,7 @@ const tests = [ }, { esm: `export * as commands from './local.js';`, - cjs: `'use strict';\n(m => Object.keys(m).map(k => k !== 'default' && (exports[k] = m[k])))\n(require('./local.js')); -` + cjs: `(m => Object.keys(m).map(k => k !== 'default' && (exports[k] = m[k])))\n(require('./local.js'));` }, // imports {