Skip to content

feat: deduplicate pypi publish workflow #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermr merged 9 commits into from
Feb 3, 2025
Merged

feat: deduplicate pypi publish workflow #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0eefc6b
feat: deduplicate pypi publish workflow
beckermr Feb 3, 2025
ceaa992
see what is there
beckermr Feb 3, 2025
fd3e0a2
fix: download to path
beckermr Feb 3, 2025
295b3e8
fix: need test then prod
beckermr Feb 3, 2025
8c3fc73
fix: remove testing items
beckermr Feb 3, 2025
6d7a1c6
Merge branch 'main' into dedupe-pypi-publish
beckermr Feb 3, 2025
acb0cfb
style: remove extra newline
beckermr Feb 3, 2025
a828f1f
style: ensure consistent caps
beckermr Feb 3, 2025
807a309
prod: cancel in progress jobs for ci
beckermr Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
pull_request:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build-docs:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
pull_request:
branches: [main, devel]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
get-versions:
runs-on: ubuntu-latest
Expand Down
81 changes: 38 additions & 43 deletions .github/workflows/publish-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,9 @@ concurrency:
cancel-in-progress: false

jobs:
publish-pypi-test:
name: Publish to TestPyPI
environment:
name: test
url: https://test.pypi.org/project/ultraplot/
build-packages:
name: Build packages
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -38,7 +32,7 @@ jobs:
python -m pip install --upgrade pip wheel setuptools setuptools_scm build twine
python -m build --sdist --wheel . --outdir dist

- name: CheckFiles
- name: Check files
run: |
ls dist
shell: bash
Expand All @@ -59,8 +53,37 @@ jobs:
popd
shell: bash

- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
name: dist-${{ github.sha }}-${{ github.run_id }}-${{ github.run_number }}
path: dist/*
if-no-files-found: error

publish-pypi-test:
name: Publish to TestPyPI
needs: build-packages
if: github.event_name != 'pull_request'
environment:
name: test
url: https://test.pypi.org/project/ultraplot/
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
steps:
- name: Download artifacts
uses: actions/download-artifact@v4
with:
name: dist-${{ github.sha }}-${{ github.run_id }}-${{ github.run_number }}
path: dist

- name: Check files
run: |
ls dist
shell: bash

- name: Publish to TestPyPI
if: github.event_name != 'pull_request'
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
Expand All @@ -69,7 +92,7 @@ jobs:
# we get a race condition if we don't skip existing
skip-existing: ${{ github.event_name == 'release' && 'true' || 'false' }}

publish-prod:
publish-pypi:
name: Publish to PyPI
needs: publish-pypi-test
environment:
Expand All @@ -81,44 +104,16 @@ jobs:
id-token: write
contents: read
steps:
- uses: actions/checkout@v4
- name: Download artifacts
uses: actions/download-artifact@v4
with:
fetch-depth: 0
name: dist-${{ github.sha }}-${{ github.run_id }}-${{ github.run_number }}

- name: Get tags
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
shell: bash

- uses: actions/setup-python@v5
with:
python-version: "3.12"

- name: Build package
run: |
python -m pip install --upgrade pip wheel setuptools setuptools_scm build twine
python -m build --sdist --wheel . --outdir dist

- name: CheckFiles
- name: Check files
run: |
ls dist
shell: bash

- name: Test wheels
run: |
pushd dist
python -m pip install ultraplot*.whl

version=$(python -c "import ultraplot; print(ultraplot.__version__)")
echo "Version: $version"
if [[ "$version" == "0."* ]]; then
echo "Version is not set correctly!"
exit 1
fi

python -m twine check *
popd
shell: bash

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
Expand Down