Skip to content

Adding pytest-mpl to ultraplot workflow #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermr merged 24 commits into from
Jan 30, 2025
Merged

Adding pytest-mpl to ultraplot workflow #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ec77184
add baseline comparison to workflow
cvanelteren Jan 30, 2025
967a038
update ticker to prevent empty comparison
cvanelteren Jan 30, 2025
7c698c5
corrected directory
cvanelteren Jan 30, 2025
18306b7
corrected 2nd part
cvanelteren Jan 30, 2025
f20a64d
removed 2nd baseline
cvanelteren Jan 30, 2025
d68dae1
Merge branch 'main' into pytest-ultraplot-corrected
beckermr Jan 30, 2025
e6d28c8
removed 2nd baseline
cvanelteren Jan 30, 2025
afabfd5
removed print
cvanelteren Jan 30, 2025
bc97945
added style
cvanelteren Jan 30, 2025
b1a02e4
add style drop on both versions
cvanelteren Jan 30, 2025
ba9a585
Update .github/workflows/build-ultraplot.yml
cvanelteren Jan 30, 2025
d20ff3c
should fail
cvanelteren Jan 30, 2025
6da4a71
should fail attempt 2
cvanelteren Jan 30, 2025
c56becd
should fail attempt 3
cvanelteren Jan 30, 2025
964d9ed
restoring after fail
cvanelteren Jan 30, 2025
129b0bc
failing again to check if html is uploaded
cvanelteren Jan 30, 2025
d19cc24
failing again to check if html is uploaded
cvanelteren Jan 30, 2025
c155da8
Update .github/workflows/build-ultraplot.yml
cvanelteren Jan 30, 2025
17cc055
set to always execute
cvanelteren Jan 30, 2025
f843e29
add continue on error
cvanelteren Jan 30, 2025
c63a045
Update main.yml
beckermr Jan 30, 2025
381d2e8
Update build-ultraplot.yml
beckermr Jan 30, 2025
03d6b4e
think it also needs other files
cvanelteren Jan 30, 2025
516bbfb
removing failure and ready for merge
cvanelteren Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/build-ultraplot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
python-version:
required: true
type: string
locale:
required: true
type: string

jobs:
build-ultraplot:
Expand Down Expand Up @@ -53,23 +56,28 @@ jobs:
- name: Generate baseline from main
shell: bash -el {0}
run: |
cd $GITHUB_WORKSPACE
mkdir -p baseline
micromamba activate ultraplot-dev
git fetch origin ${{ github.event.pull_request.base.sha }}
git checkout ${{ github.event.pull_request.base.sha }}
pytest --mpl-generate-path=baseline_images
python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')"
pytest --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml"
git checkout ${{ github.sha }} # Return to PR branch

- name: Image Comparison Ultraplot
shell: bash -el {0}
run: |
cd $GITHUB_WORKSPACE
micromamba activate ultraplot-dev
pytest --mpl-generate-path=baseline_images --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())")
mkdir -p results
python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')"
pytest --mpl --mpl-baseline-path=baseline --mpl-generate-summary=html --mpl-results-path=./results/ --mpl-default-style="./ultraplot.yml"

# return the images that failed
# Return the html output of the comparison even if failed
- name: Upload comparison failures
if: failure()
if: always()
uses: actions/upload-artifact@v4
with:
name: failed-comparisons
path: result_images
name: failed-comparisons-${{ inputs.python-version }}-${{ inputs.locale }}
path: results/*
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,4 @@ jobs:
uses: ./.github/workflows/build-ultraplot.yml
with:
python-version: ${{ matrix.python-version }}
locale: ${{ matrix.locale }}