From ec7718489d8c66f8b4075bd678d12eb614b40c75 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 09:29:07 +0100 Subject: [PATCH 01/23] add baseline comparison to workflow --- .github/workflows/build-ultraplot.yml | 60 +++++++++++++++++---------- 1 file changed, 37 insertions(+), 23 deletions(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index e082dd60c..a31a901c8 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -35,27 +35,41 @@ jobs: micromamba activate ultraplot-dev pytest - # Skip pytest-mpl for now as it removes the RC file - # Future should include it though! See https://github.com/matplotlib/pytest-mpl/issues/236 - # - name: Generate baseline from main - # shell: bash -el {0} - # run: | - # mkdir -p baseline - # micromamba activate ultraplot-dev - # git fetch origin ${{ github.event.pull_request.base.sha }} - # git checkout ${{ github.event.pull_request.base.sha }} - # pytest --mpl-generate-path=baseline_images - # git checkout ${{ github.sha }} # Return to PR branch - # - name: Image Comparison Ultraplot - # shell: bash -el {0} - # run: | - # micromamba activate ultraplot-dev - # pytest --mpl --mpl-baseline-path=baseline_images + compare-baseline: + needs: build-ultraplot + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: mamba-org/setup-micromamba@v2.0.4 + with: + environment-file: ./environment.yml + init-shell: bash + create-args: >- + --verbose + python=${{ inputs.python-version }} + cache-environment: true + cache-downloads: false + + - name: Generate baseline from main + shell: bash -el {0} + run: | + mkdir -p baseline + micromamba activate ultraplot-dev + git fetch origin ${{ github.event.pull_request.base.sha }} + git checkout ${{ github.event.pull_request.base.sha }} + pytest --mpl-generate-path=baseline_images + git checkout ${{ github.sha }} # Return to PR branch - # # return the images that failed - # - name: Upload comparison failures - # if: failure() - # uses: actions/upload-artifact@v4 - # with: - # name: failed-comparisons - # path: result_images + - name: Image Comparison Ultraplot + shell: bash -el {0} + run: | + micromamba activate ultraplot-dev + pytest --mpl-generate-path=baseline_images --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())") + + # return the images that failed + - name: Upload comparison failures + if: failure() + uses: actions/upload-artifact@v4 + with: + name: failed-comparisons + path: result_images From 967a0383548010fd3563d0eb0e5492f1e2630e20 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 09:53:26 +0100 Subject: [PATCH 02/23] update ticker to prevent empty comparison --- ultraplot/ticker.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ultraplot/ticker.py b/ultraplot/ticker.py index 670f532ef..fefe13170 100644 --- a/ultraplot/ticker.py +++ b/ultraplot/ticker.py @@ -241,9 +241,15 @@ def tick_values(self, vmin, vmax): # noqa: U100 step = step // i break diff = np.abs(np.diff(locs[: step + 1 : step])) - (offset,) = np.where(np.isclose(locs % diff if diff.size else 0.0, 0.0)) - offset = offset[0] if offset.size else np.argmin(np.abs(locs)) - return locs[offset % step :: step] # even multiples from zero or zero-close + + if diff.size: + matches = np.where(np.isclose(locs % diff, 0.0))[0] + offset = matches[0] if len(matches) else np.argmin(np.abs(locs)) + else: + offset = np.argmin(np.abs(locs)) + return locs[ + int(offset) % step :: step + ] # even multiples from zero or zero-close class DegreeLocator(mticker.MaxNLocator): From 7c698c582f7cade904ce9c9987c6e7813110f9e2 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 13:58:11 +0100 Subject: [PATCH 03/23] corrected directory --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index a31a901c8..ebe89c01c 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -64,7 +64,7 @@ jobs: shell: bash -el {0} run: | micromamba activate ultraplot-dev - pytest --mpl-generate-path=baseline_images --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())") + pytest --mpl-generate-path=baseline --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())") # return the images that failed - name: Upload comparison failures From 18306b71910ff70e4a243a40f250ec3e394b8242 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 14:02:49 +0100 Subject: [PATCH 04/23] corrected 2nd part --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index ebe89c01c..f5bf877dc 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -57,7 +57,7 @@ jobs: micromamba activate ultraplot-dev git fetch origin ${{ github.event.pull_request.base.sha }} git checkout ${{ github.event.pull_request.base.sha }} - pytest --mpl-generate-path=baseline_images + pytest --mpl-generate-path=baseline git checkout ${{ github.sha }} # Return to PR branch - name: Image Comparison Ultraplot From f20a64de28e58f177ba0b3fb05b00b02dc915fac Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 14:04:09 +0100 Subject: [PATCH 05/23] removed 2nd baseline --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index f5bf877dc..2ad31d528 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -64,7 +64,7 @@ jobs: shell: bash -el {0} run: | micromamba activate ultraplot-dev - pytest --mpl-generate-path=baseline --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())") + pytest --mpl --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())") # return the images that failed - name: Upload comparison failures From e6d28c8b844ada24b4b75dac2f982c94ca25f6a9 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 14:43:11 +0100 Subject: [PATCH 06/23] removed 2nd baseline --- .github/workflows/build-ultraplot.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 2ad31d528..3fc2f1d6e 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -53,6 +53,7 @@ jobs: - name: Generate baseline from main shell: bash -el {0} run: | + cd $GITHUB_WORKSPACE mkdir -p baseline micromamba activate ultraplot-dev git fetch origin ${{ github.event.pull_request.base.sha }} @@ -63,8 +64,11 @@ jobs: - name: Image Comparison Ultraplot shell: bash -el {0} run: | + cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev - pytest --mpl --mpl-default-style $(python -c "import ultraplot as plt; print(plt.config.Configurator())") + python -c "import ultraplot as plt; print; plt.config.Configurator()._save_yaml('ultraplot.yml')" + ls -la ultraplot.yml + pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" # return the images that failed - name: Upload comparison failures From afabfd5931accf8fc1e10fa590f7178ffaf05489 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 14:44:48 +0100 Subject: [PATCH 07/23] removed print --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 3fc2f1d6e..d7b170190 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -66,7 +66,7 @@ jobs: run: | cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev - python -c "import ultraplot as plt; print; plt.config.Configurator()._save_yaml('ultraplot.yml')" + python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" ls -la ultraplot.yml pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" From bc97945dd32ef778c6dfcc7f7096f849ed0360ea Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 15:28:22 +0100 Subject: [PATCH 08/23] added style --- .github/workflows/build-ultraplot.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index d7b170190..0dc4d2493 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -58,7 +58,8 @@ jobs: micromamba activate ultraplot-dev git fetch origin ${{ github.event.pull_request.base.sha }} git checkout ${{ github.event.pull_request.base.sha }} - pytest --mpl-generate-path=baseline + python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" + pytest --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" git checkout ${{ github.sha }} # Return to PR branch - name: Image Comparison Ultraplot @@ -66,7 +67,6 @@ jobs: run: | cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev - python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" ls -la ultraplot.yml pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" From b1a02e416d8f6eee7769fd2f0f9fe85130a65e06 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 15:29:35 +0100 Subject: [PATCH 09/23] add style drop on both versions --- .github/workflows/build-ultraplot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 0dc4d2493..203a4d767 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -68,6 +68,7 @@ jobs: cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev ls -la ultraplot.yml + python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" # return the images that failed From ba9a5855fafce3e98ce0f0123ba3e0506d7fc28b Mon Sep 17 00:00:00 2001 From: Casper van Elteren Date: Thu, 30 Jan 2025 15:57:28 +0100 Subject: [PATCH 10/23] Update .github/workflows/build-ultraplot.yml Co-authored-by: Matthew R. Becker --- .github/workflows/build-ultraplot.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 203a4d767..4eac6266c 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -67,7 +67,6 @@ jobs: run: | cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev - ls -la ultraplot.yml python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" From d20ff3cd91911fb586dbdc3191a882bd50f9ea75 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 16:29:31 +0100 Subject: [PATCH 11/23] should fail --- .github/workflows/build-ultraplot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 4eac6266c..789c06cc0 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -68,6 +68,7 @@ jobs: cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" + sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" # return the images that failed From 6da4a7112b929e768484c53341ee704c884549b2 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 16:41:00 +0100 Subject: [PATCH 12/23] should fail attempt 2 --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 789c06cc0..b65785d2e 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -69,7 +69,7 @@ jobs: micromamba activate ultraplot-dev python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml - pytest --mpl --mpl-generate-path=baseline --mpl-default-style="./ultraplot.yml" + pytest --mpl --mpl-default-style="./ultraplot.yml" # return the images that failed - name: Upload comparison failures From c56becdde541717879bbd6664b2989cdc677b6f7 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 16:45:15 +0100 Subject: [PATCH 13/23] should fail attempt 3 --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index b65785d2e..4f1c28848 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -69,7 +69,7 @@ jobs: micromamba activate ultraplot-dev python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml - pytest --mpl --mpl-default-style="./ultraplot.yml" + pytest --mpl --mpl-baseline-path=baseline --mpl-default-style="./ultraplot.yml" # return the images that failed - name: Upload comparison failures From 964d9ed98f7eb60c0a66905883f50db8d0b5f573 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 16:59:48 +0100 Subject: [PATCH 14/23] restoring after fail --- .github/workflows/build-ultraplot.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 4f1c28848..ba3dd59bd 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -68,7 +68,6 @@ jobs: cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" - sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml pytest --mpl --mpl-baseline-path=baseline --mpl-default-style="./ultraplot.yml" # return the images that failed From 129b0bce52939ca6ec527ad6168fce5a47e6e97d Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 19:22:27 +0100 Subject: [PATCH 15/23] failing again to check if html is uploaded --- .github/workflows/build-ultraplot.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index ba3dd59bd..61bef7183 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -67,13 +67,14 @@ jobs: run: | cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev + mkdir -P results python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" - pytest --mpl --mpl-baseline-path=baseline --mpl-default-style="./ultraplot.yml" + sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml + pytest --mpl --mpl-baseline-path=baseline --mpl-generate-summary=html --mpl-results-path = ./results/ --mpl-default-style="./ultraplot.yml" - # return the images that failed + # Return the html output of the comparison even if failed - name: Upload comparison failures - if: failure() uses: actions/upload-artifact@v4 with: name: failed-comparisons - path: result_images + path: results/*.html From d19cc24e6ff1e2e4e3f98925e257bcb7b0558cfc Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 19:22:58 +0100 Subject: [PATCH 16/23] failing again to check if html is uploaded --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 61bef7183..b2bc05fc9 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -67,7 +67,7 @@ jobs: run: | cd $GITHUB_WORKSPACE micromamba activate ultraplot-dev - mkdir -P results + mkdir -p results python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml pytest --mpl --mpl-baseline-path=baseline --mpl-generate-summary=html --mpl-results-path = ./results/ --mpl-default-style="./ultraplot.yml" From c155da8f755d1d44a3a3023461d0bb3b68f24818 Mon Sep 17 00:00:00 2001 From: Casper van Elteren Date: Thu, 30 Jan 2025 19:27:28 +0100 Subject: [PATCH 17/23] Update .github/workflows/build-ultraplot.yml Co-authored-by: Matthew R. Becker --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index b2bc05fc9..457da1da5 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -70,7 +70,7 @@ jobs: mkdir -p results python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml - pytest --mpl --mpl-baseline-path=baseline --mpl-generate-summary=html --mpl-results-path = ./results/ --mpl-default-style="./ultraplot.yml" + pytest --mpl --mpl-baseline-path=baseline --mpl-generate-summary=html --mpl-results-path=./results/ --mpl-default-style="./ultraplot.yml" # Return the html output of the comparison even if failed - name: Upload comparison failures From 17cc055ebff05f179bc95650b5709d53f421bf5b Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 20:09:20 +0100 Subject: [PATCH 18/23] set to always execute --- .github/workflows/build-ultraplot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index 457da1da5..e5425d0e6 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -74,6 +74,7 @@ jobs: # Return the html output of the comparison even if failed - name: Upload comparison failures + if: always() uses: actions/upload-artifact@v4 with: name: failed-comparisons From f843e29a072e906f9de5ed2011db282e3814c081 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 20:29:03 +0100 Subject: [PATCH 19/23] add continue on error --- .github/workflows/build-ultraplot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index e5425d0e6..e49a125ac 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -63,6 +63,7 @@ jobs: git checkout ${{ github.sha }} # Return to PR branch - name: Image Comparison Ultraplot + continue-on-error: true shell: bash -el {0} run: | cd $GITHUB_WORKSPACE From c63a0457787bd9f5c06a37f66b99a5ac55406635 Mon Sep 17 00:00:00 2001 From: "Matthew R. Becker" Date: Thu, 30 Jan 2025 13:29:45 -0600 Subject: [PATCH 20/23] Update main.yml --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3b6504159..67ac6369c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -69,3 +69,4 @@ jobs: uses: ./.github/workflows/build-ultraplot.yml with: python-version: ${{ matrix.python-version }} + locale: ${{ matrix.locale }} From 381d2e894cc1cae22f0b60509fdba7bd4b0850bd Mon Sep 17 00:00:00 2001 From: "Matthew R. Becker" Date: Thu, 30 Jan 2025 13:30:19 -0600 Subject: [PATCH 21/23] Update build-ultraplot.yml --- .github/workflows/build-ultraplot.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index e49a125ac..c8708d48d 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -5,6 +5,9 @@ on: python-version: required: true type: string + locale: + required: true + type: string jobs: build-ultraplot: @@ -63,7 +66,6 @@ jobs: git checkout ${{ github.sha }} # Return to PR branch - name: Image Comparison Ultraplot - continue-on-error: true shell: bash -el {0} run: | cd $GITHUB_WORKSPACE @@ -78,5 +80,5 @@ jobs: if: always() uses: actions/upload-artifact@v4 with: - name: failed-comparisons + name: failed-comparisons-${{ inputs.python-version }}-${{ inputs.locale }} path: results/*.html From 03d6b4e07c5a9dd673dfdbcce7256803f1e89b60 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 20:48:06 +0100 Subject: [PATCH 22/23] think it also needs other files --- .github/workflows/build-ultraplot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index c8708d48d..f3d27cae1 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -81,4 +81,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: failed-comparisons-${{ inputs.python-version }}-${{ inputs.locale }} - path: results/*.html + path: results/* From 516bbfb95208a83721e55834cf63dfeb1b93d466 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Thu, 30 Jan 2025 21:08:39 +0100 Subject: [PATCH 23/23] removing failure and ready for merge --- .github/workflows/build-ultraplot.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build-ultraplot.yml b/.github/workflows/build-ultraplot.yml index f3d27cae1..8746dda49 100644 --- a/.github/workflows/build-ultraplot.yml +++ b/.github/workflows/build-ultraplot.yml @@ -72,7 +72,6 @@ jobs: micromamba activate ultraplot-dev mkdir -p results python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')" - sed -i 's/grid.color: *black/grid.color: red/' ultraplot.yml pytest --mpl --mpl-baseline-path=baseline --mpl-generate-summary=html --mpl-results-path=./results/ --mpl-default-style="./ultraplot.yml" # Return the html output of the comparison even if failed