Merged
Conversation
add status bar item to RunLineInEditor class add execution timing to RunLineInEditor class
chrmarti
requested changes
Jun 26, 2019
more specific variable names handle running multiple commands simultaneously fix status bar item dispose fix promise chaining
Contributor
|
Nice! I'm tweaking the messages a little so they read 'Azure CLI' (I don't think we 'AZ CLI' elsewhere) and are slightly shorter. With that I'll merge it for the release I'm about to make. Hope that's fine with you. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add spinner to status bar while the AZ command is executing. Show command duration when execution is finished and hide 10 seconds after command is finished executing.