Skip to content

Commit 0ffc3f7

Browse files
committed
use initSafeStandardObjects() instead of initStandardObjects() to avoid execution of arbitrary (java) code
1 parent dfa6ffc commit 0ffc3f7

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/main/java/com/gargoylesoftware/htmlunit/ProxyAutoConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static String evaluate(final String content, final URL url) {
5555
final Context cx = Context.enter();
5656
try {
5757
final ProxyAutoConfig config = new ProxyAutoConfig();
58-
final Scriptable scope = cx.initStandardObjects();
58+
final Scriptable scope = cx.initSafeStandardObjects();
5959

6060
config.defineMethod("isPlainHostName", scope);
6161
config.defineMethod("dnsDomainIs", scope);

src/main/java/com/gargoylesoftware/htmlunit/javascript/JavaScriptEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ private void init(final WebWindow webWindow, final Context context) throws Excep
202202

203203
final Window window = new Window();
204204
((SimpleScriptable) window).setClassName("Window");
205-
context.initStandardObjects(window);
205+
context.initSafeStandardObjects(window);
206206

207207
final ClassConfiguration windowConfig = jsConfig_.getClassConfiguration("Window");
208208
if (windowConfig.getJsConstructor() != null) {

src/main/java/com/gargoylesoftware/htmlunit/javascript/host/worker/DedicatedWorkerGlobalScope.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public DedicatedWorkerGlobalScope() {
8282
*/
8383
DedicatedWorkerGlobalScope(final Window owningWindow, final Context context, final BrowserVersion browserVersion,
8484
final Worker worker) throws Exception {
85-
context.initStandardObjects(this);
85+
context.initSafeStandardObjects(this);
8686

8787
final ClassConfiguration config = AbstractJavaScriptConfiguration.getClassConfiguration(
8888
DedicatedWorkerGlobalScope.class, browserVersion);

0 commit comments

Comments
 (0)