Open buff2String to everyone

fix all the stream stuff so we can start saving logs to s3

Author: Nathan219

lib/socket/common-stream.js

@@ -152,6 +152,7 @@ function pipeLogsToClient (clientStream, baseDataName, tags, containerId, opts)
 }
 
 module.exports = {
+  buff2StringTransform: buff2StringTransform,
   onValidateFailure: onValidateFailure,
   pipeLogsToClient: pipeLogsToClient,
   pipeAndEndOnError: pipeAndEndOnError,

lib/workers/container.logs.store.js

@@ -1,6 +1,6 @@
 /**
- * Handle instance container died event
- * @module lib/workers/application.container.died
+ * Handle instance container log store events
+ * @module lib/workers/container.log.store
  */
 'use strict'
 
@@ -10,13 +10,12 @@ const joi = require('utils/joi')
 const logger = require('logger')
 const WorkerStopError = require('error-cat/errors/worker-stop-error')
 const commonStream = require('socket/common-stream')
-const through2 = require('through2')
+const Through2 = require('through2')
 const aws = require('aws-sdk')
 const Docker = require('models/apis/docker')
 
 const s3 = new aws.S3()
 
-
 module.exports.jobSchema = joi.object({
   containerId: joi.string().required()
 }).unknown().required()
@@ -34,26 +33,13 @@ module.exports.task = (job) => {
         bucket: `${process.env.NODE_ENV}.container-logs`,
         key: job.containerId
       }, 'Began piping logs')
-
-      const cleanedStream = new through2({objectMode:true})
-
-      cleanedStream.on('error', (err) => {
-        log.error({err}, 'Stream error')
-      })
-      cleanedStream.on('end', () => {
-        log.trace('Cleaned stream ended')
-      })
-      cleanedStream.on('data', (data) => {
-        log.trace({data: data.toString()}, 'Got actual stream data')
-      })
-
+      const cleanedStream = new Through2({}, commonStream.buff2StringTransform)
       commonStream.connectStream(dockerLogStream, cleanedStream, log)
 
       dockerLogStream.on('end', () => {
         log.trace('Dockerlog stream ended')
         cleanedStream.end()
       })
-
       // Send stream to s3
       return s3.upload({
         Bucket: `${process.env.NODE_ENV}.container-logs`,